Skip to content

url: add value argument to has and delete methods #47885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 13 commits into from
May 14, 2023
Merged

url: add value argument to has and delete methods #47885

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
7d99ffc
url: add value argument to has and delete methods
sankalp1999 May 5, 2023
ecf95b5
url: add wpt tests
sankalp1999 May 5, 2023
5031f58
url: ran linter
sankalp1999 May 5, 2023
f1845e3
fixup! refactor delete method one loop into two for better readability
sankalp1999 May 6, 2023
2846704
url: refactor has method
sankalp1999 May 6, 2023
a0522c8
url: correction in hsa method, exact key-value tuple search
sankalp1999 May 6, 2023
3c1521f
doc: update has method and delete method
sankalp1999 May 6, 2023
e66fe1e
fixup! add changes in doc and refactor urlsearchparam-has
sankalp1999 May 6, 2023
68624b3
fixup! add default arg as undefined to value
sankalp1999 May 8, 2023
29c316c
tools: fix to accommodate base as null, benchmark test fixed
sankalp1999 May 8, 2023
9126a64
fixup! refactor delete method and minor correction in docs
sankalp1999 May 8, 2023
3b19423
url: refactor conditional statements in the loop
sankalp1999 May 8, 2023
fb0e57d
fixup! minor changes in docs
sankalp1999 May 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
doc: update has method and delete method
  • Loading branch information
@sankalp1999
sankalp1999 committed May 8, 2023
commit 3c1521fef26b003c5fe507ad2690e07878e79ca5
20 changes: 16 additions & 4 deletions doc/api/url.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -859,11 +859,15 @@ new URLSearchParams([

Append a new name-value pair to the query string.

#### `urlSearchParams.delete(name)`
#### `urlSearchParams.delete(name, value)`

Comment thread
anonrig marked this conversation as resolved.
* `name` {string}
* `value` {string}

If `value` is provided, then delete all name-value pairs with
Copy link
Copy Markdown
Contributor

@aduh95 aduh95 May 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The phrasing should be consistent between the two paragraphs.

Suggested change
If `value` is provided, then delete all name-value pairs with
If `value` is provided, removes all name-value pairs with

Copy link
Copy Markdown
Contributor Author

@sankalp1999 sankalp1999 May 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

whose `name` is name and `value` is value.
Copy link
Copy Markdown
Contributor

@aduh95 aduh95 May 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
whose `name` is name and `value` is value.
whose name is `name` and value is `value`.


Remove all name-value pairs whose name is `name`.
If `value` not provided, remove all name-value pairs whose name is `name`.
Comment thread
debadree25 marked this conversation as resolved.
Outdated

#### `urlSearchParams.entries()`

Expand Down Expand Up @@ -918,12 +922,20 @@ are no such pairs, `null` is returned.
Returns the values of all name-value pairs whose name is `name`. If there are
no such pairs, an empty array is returned.

#### `urlSearchParams.has(name)`
#### `urlSearchParams.has(name, value)`

* `name` {string}
* `value` {string}
* Returns: {boolean}

Returns `true` if there is at least one name-value pair whose name is `name`.
Checks if the `URLSearchParams` object contains key-value pair(s) based on
`name` and an optional `value` argument.

If `value` is provided, returns true when name-value pair with
Comment thread
sankalp1999 marked this conversation as resolved.
Outdated
same `name` and `value` exists.

If `value` is not provided, returns `true` if there is at least one name-value
pair whose name is `name`.

#### `urlSearchParams.keys()`

Expand Down