net: add note about ipv4 mapped to ipv6 being classified as ipv6#62117
Open
gamemaker1 wants to merge 1 commit intonodejs:mainfrom
Open
net: add note about ipv4 mapped to ipv6 being classified as ipv6#62117gamemaker1 wants to merge 1 commit intonodejs:mainfrom
gamemaker1 wants to merge 1 commit intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
This PR adds a note and examples to the documentation of the
isIPandisIPv6methods, informing the reader that IPv4 addresses mapped to IPv6 are classified as IPv6.This is not related to an existing issue, as far as I could find. I am opening this PR in the context of GHSA-46wh-pxpv-q5gq.
Please let me know if I have made any mistake, or if this change is not something that you want to merge.
Thanks!