test: keep finalization ref alive until exit#63394
Draft
trivikr wants to merge 1 commit into
Draft
Conversation
Keep the registered finalization object strongly reachable until process exit so the test does not depend on GC timing. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #63394 +/- ##
=======================================
Coverage 90.05% 90.05%
=======================================
Files 714 714
Lines 225656 225704 +48
Branches 42696 42717 +21
=======================================
+ Hits 203214 203267 +53
- Misses 14220 14231 +11
+ Partials 8222 8206 -16 🚀 New features to boost your workflow:
|
Member
Author
|
Converted to draft, as the flaky test is likely fixed by #63209 The PRs for which the CI failed on https://github.com/nodejs/reliability/blob/main/reports/2026-05-15.md#jstest-failure did not contain the fix from #63209. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an intermittent failure in
parallel/test-process-finalization.The
different-registry-per-thread.mjsfixture registered an object withprocess.finalization.register()but did not keep that object stronglyreachable until process exit. Since finalization stores weak references, GC
could collect the main-thread object before shutdown, causing the expected
shutdown on main threadoutput to be missing.This keeps the registered reference reachable through the
exitphase so thetest verifies per-thread finalization behavior without depending on GC timing.
Refs: https://github.com/nodejs/reliability/blob/main/reports/2026-05-15.md#jstest-failure
Assisted-by: openai:gpt-5.5