src: update node.cc and related for z/OS by gabylb · Pull Request #66569 · nodejs/node

gabylb · 2026-10-07T14:06:14Z

Updates here apply to z/OS only.

Add new src/node_zos.h and src/node_zos.cc, used by src/node.cc.
Add new src/zos_setlibpath.cc and link its .o directly into node so the __setlibpath object's constructor finds libnode.so and add its path to LIBPATH, so it can be loaded.
Pass '-Wl,-bedit=no' when linking libnode.so to reduce its size.
Use z/OS specific signal handling logic, as signals on z/OS must be handled in a dedicated thread.
Force V8 flag --nohard_abort due to absence of XPLINK headers in JS generated code.
Include display of zoslib build version.

nodejs-github-bot · 2026-10-07T14:06:21Z

Review requested:

@nodejs/gyp
@nodejs/startup

inoway46 · 2026-10-07T14:29:06Z

Thanks for working on this! The commit and lint checks are currently failing. Have you also verified that this builds successfully locally?

Please follow the guide below:
https://github.com/nodejs/node/blob/main/doc/contributing/pull-requests.md

codecov · 2026-10-07T16:42:34Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.48%. Comparing base (a7a96c2) to head (c484ca3).

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #66569   +/-   ##
=======================================
  Coverage   90.47%   90.48%           
=======================================
  Files         791      791           
  Lines      277088   277088           
  Branches    53286    53276   -10     
=======================================
+ Hits       250703   250715   +12     
+ Misses      16805    16771   -34     
- Partials     9580     9602   +22

Files with missing lines	Coverage Δ
src/node.cc	`79.24% <ø> (ø)`

... and 33 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

gabylb · 2026-10-07T19:05:01Z

Thanks for working on this! The commit and lint checks are currently failing. Have you also verified that this builds successfully locally?

Please follow the guide below: https://github.com/nodejs/node/blob/main/doc/contributing/pull-requests.md

Hello Yuya. This PR is part of a number of PRs to be opened for the z/OS port; in our environment, which includes all the port, node builds successfully.

addaleax · 2026-10-08T14:20:50Z

  sa.sa_sigaction = handler;
  sa.sa_flags = reset_handler ? SA_RESETHAND : 0;
+#ifdef __MVS__
+  sa.sa_flags |= SA_ONSTACK | SA_SIGINFO;


A lot of these changes could use comments that explain why specifically z/OS needs these and other OSes don't – e.g. SA_ONSTACK and SA_SIGINFO aren't z/OS-specific per se, so it's not obvious why the conditional is here (I might guess because of SIGABRT being listed below as a handled signal – but let's not have this be a silent assumption?)

Please see https://www.ibm.com/docs/en/zos/3.1.0?topic=functions-sigaction-examine-change-signal-action.
For SA_SIGINFO, sa_sigaction is specified for the sigaction() call here. For SA_ONSTACK, it's to use the alternate signal stack created initially in zosStart(), to not interfere with the z/OS Language Environment runtime environment.

Would you like such comments added in the code, or in the commit's message?

I've added a comment for this case inline.

Anything else for this PR in particular that requires explanation? Do you prefer comments from the PR's description to be added around the affected code?

Yes, more code comments around the #ifdef guards is preferable.

inoway46 · 2026-10-10T14:29:45Z

The QUIC build failure has been fixed in #66603. Rebasing onto the latest main should resolve it.

- Add new src/node_zos.h and src/node_zos.cc, used by src/node.cc. - Add new src/zos_setlibpath.cc and link its .o directly into node so the __setlibpath object's constructor finds libnode.so and add its path to LIBPATH, so it can be loaded. - Pass '-Wl,-bedit=no' when linking libnode.so to reduce its size. - Use z/OS specific signal handling logic, as signals on z/OS must be handled in a dedicated thread. - Force V8 flag --nohard_abort due to absence of XPLINK headers in JS generated code. - Include display of zoslib build version. Signed-off-by: Gaby Baghdadi <baghdadi@ca.ibm.com>

Signed-off-by: Gaby Baghdadi <baghdadi@ca.ibm.com>

jasnell · 2026-11-05T23:06:06Z

+// Copyright Joyent, Inc. and other Node contributors.
+//
+// Permission is hereby granted, free of charge, to any person obtaining a
+// copy of this software and associated documentation files (the
+// "Software"), to deal in the Software without restriction, including
+// without limitation the rights to use, copy, modify, merge, publish,
+// distribute, sublicense, and/or sell copies of the Software, and to permit
+// persons to whom the Software is furnished to do so, subject to the
+// following conditions:
+//
+// The above copyright notice and this permission notice shall be included
+// in all copies or substantial portions of the Software.
+//
+// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
+// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
+// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN
+// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,
+// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
+// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
+// USE OR OTHER DEALINGS IN THE SOFTWARE.


Do not include the copyright header in new files.

jasnell · 2026-11-05T23:10:23Z

+// (C) Copyright IBM Corp. 2024. All Rights Reserved.
+// US Government Users Restricted Rights - Use, duplication
+// or disclosure restricted by GSA ADP Schedule Contract with IBM Corp.
+///////////////////////////////////////////////////////////////////////////////


If this is pulling from a different project, the license file script needs to be updated to account for it. What is the license of that other work? We cannot bundle this file without a clear indication of a compatible OSS license. Minus such a license, there is no indication that you have the rights to contribute this code to the project. It appears you are from IBM but that alone is not sufficient here.

jasnell

The license of the zos_setlibpath.cc file needs to be clarified before this can be merged.

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run. labels Oct 7, 2026

gabylb marked this pull request as draft October 7, 2026 15:19

gabylb force-pushed the zos-src branch from 9c8e157 to 63a1aec Compare October 7, 2026 18:47

gabylb marked this pull request as ready for review October 7, 2026 19:05

gabylb force-pushed the zos-src branch from 63a1aec to f5c1ac1 Compare October 7, 2026 19:31

richardlau mentioned this pull request Oct 8, 2026

build: run QUIC CI for V8 changes #66602

Merged

addaleax reviewed Oct 8, 2026

View reviewed changes

gabylb force-pushed the zos-src branch from 36e2894 to c903803 Compare October 11, 2026 18:47

gabylb added 3 commits October 12, 2026 10:19

src: address review comments

0ddf4e3

Signed-off-by: Gaby Baghdadi <baghdadi@ca.ibm.com>

src: comment guarded use of SA_ONSTACK | SA_SIGINFO

c484ca3

Signed-off-by: Gaby Baghdadi <baghdadi@ca.ibm.com>

gabylb force-pushed the zos-src branch from c903803 to c484ca3 Compare October 12, 2026 14:27

gabylb requested a review from addaleax October 12, 2026 14:30

jasnell reviewed Nov 5, 2026

View reviewed changes

jasnell requested changes Nov 5, 2026

View reviewed changes

Conversation

gabylb commented Oct 7, 2026

Uh oh!

nodejs-github-bot commented Oct 7, 2026

Uh oh!

inoway46 commented Oct 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Oct 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

gabylb commented Oct 7, 2026

Uh oh!

addaleax Oct 8, 2026

Choose a reason for hiding this comment

Uh oh!

gabylb Oct 8, 2026

Choose a reason for hiding this comment

Uh oh!

gabylb Oct 12, 2026

Choose a reason for hiding this comment

Uh oh!

gabylb Nov 5, 2026

Choose a reason for hiding this comment

Uh oh!

jasnell Nov 5, 2026

Choose a reason for hiding this comment

Uh oh!

inoway46 commented Oct 10, 2026

Uh oh!

jasnell Nov 5, 2026

Choose a reason for hiding this comment

Uh oh!

jasnell Nov 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jasnell left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

inoway46 commented Oct 7, 2026 •

edited

Loading

codecov Bot commented Oct 7, 2026 •

edited

Loading

jasnell Nov 5, 2026 •

edited

Loading