DOC: Use SPDX license expressions with correct license#17238
Merged
Conversation
tools/npy_tempita/license.txt license is MIT not a "BSD Derived" Also use SPDX license identifiers and expressions for clarity Based on original report at aboutcode-org/scancode-toolkit#2189 Reported-by: Frank Viernau <frank.viernau@here.com> Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Member
|
LGTM, but I am unfamiliar with SPDX. |
charris
reviewed
Sep 3, 2020
| Name: scipy-sphinx-theme | ||
| Files: doc/scipy-sphinx-theme/* | ||
| License: 3-clause BSD, PSF and Apache 2.0 | ||
| License: BSD-3-clause AND PSF-2.0 AND Apache-2.0 |
Member
There was a problem hiding this comment.
Out of curiosity, why the changed use of "AND"?
Member
There was a problem hiding this comment.
Member
There was a problem hiding this comment.
The specs seem to spell it BSD-3-Clause with a capital c, but I guess that just doesn't matter, if the auto-tool doesn't complain.
Contributor
Author
Contributor
Author
There was a problem hiding this comment.
@charris you wrote:
Out of curiosity, why the changed use of "AND"?
because the three licenses apply there https://github.com/scipy/scipy-sphinx-theme/blob/59c27fdde3ec4c78eb93b5e375d203ec5707382a/LICENSE.txt
Reported-by: Sebastian Berg <sebastian@sipsolutions.net> Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Member
|
Thanks @pombredanne, no point in waiting for the tests on this. |
charris
pushed a commit
to charris/numpy
that referenced
this pull request
Sep 3, 2020
* Use SPDX license expressions with correct license tools/npy_tempita/license.txt license is MIT not a "BSD Derived" Also use SPDX license identifiers and expressions for clarity Based on original report at aboutcode-org/scancode-toolkit#2189 Reported-by: Frank Viernau <frank.viernau@here.com> Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com> * Use correct case for BSD licenses identifers Reported-by: Sebastian Berg <sebastian@sipsolutions.net> Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After a check I found that
tools/npy_tempita/license.txt licenseis an MIT license and not a "BSD Derived" as reported.I also propose to use SPDX license identifiers and license expressions for improved clarity and update the file accordingly.
This is based on a scan I ran after an original report at aboutcode-org/scancode-toolkit#2189
Reported-by: Frank Viernau frank.viernau@here.com
Signed-off-by: Philippe Ombredanne pombredanne@nexb.com