Skip to content

MAINT: Cleanup swig for Python 3.#17580

Merged
mattip merged 1 commit into
numpy:masterfrom
charris:cleanup-swig-for-python3
Oct 24, 2020
Merged

MAINT: Cleanup swig for Python 3.#17580
mattip merged 1 commit into
numpy:masterfrom
charris:cleanup-swig-for-python3

Conversation

@charris

@charris charris commented Oct 18, 2020

Copy link
Copy Markdown
Member

Replaces PyInt_Check and PyInt_AsLong in a few places.

Replaces ``PyInt_Check`` and ``PyInt_AsLong`` in a few places.
@charris charris force-pushed the cleanup-swig-for-python3 branch from 33a28bc to cf06cd4 Compare October 18, 2020 21:05
@charris

charris commented Oct 18, 2020

Copy link
Copy Markdown
Member Author

@mlamarre Could you take a look? I'm unfamiliar with the swig conventions.

@eric-wieser eric-wieser left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me

@mattip mattip merged commit d483de0 into numpy:master Oct 24, 2020
@mattip

mattip commented Oct 24, 2020

Copy link
Copy Markdown
Member

Thanks @charris

@charris charris deleted the cleanup-swig-for-python3 branch December 19, 2020 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants