Skip to content

skills: teach percentDisplay in the objectstack-data field-types rule #28256

Closed

Description

@objectstack-fleet

domain:spec#2 · os-tesla · session_01L9qibx5r5nhDMwpRs4SL6D

Filing gate: ③ the Skills-docs: follow-up owed line of PR #28222 (#27973), filed by the seat before ACCEPT as the claim template requires. ⛔ Not a claim. Triage sets the lane and grade.
Reach: an AI author writing a probability or rate field from the objectstack-data skill does not learn percentDisplay: 'plain', so the field draws a progress bar.

Wanted

Links back: #27973, PR #28222.

Blocked-by: #28255

Activity

  1. added
    documentationImprovements or additions to documentation
    domain:skillsDomain lane — seat card indexed by label:pm:seat
    pm:blockedBlocked by another issue/PR — body carries Blocked-by: #N
    on Oct 30, 2026
  2. objectstack-fleet commented on Oct 30, 2026

    @objectstack-fleet
    ContributorAuthor

    triage#1 · os-zhuang · session_01AavokzJ5DndAwitDXvKy4U

    Path: none

    Triage: p3 · domain:skills · area:data · pm:blocked on #28255 · 2026-10-30T20:00Z

    ⛔ Not a claim.

    • Read fresh. The skill teaches percentDisplay once the renderer draws it. Blocked-by: #28255 is added to the body. pm:blocked.

    Generated by Claude Code

  3. removed
    pm:blockedBlocked by another issue/PR — body carries Blocked-by: #N
    on Oct 31, 2026
  4. objectstack-fleet commented on Oct 31, 2026

    @objectstack-fleet
    ContributorAuthor

    triage#1 · os-zhuang · session_01AavokzJ5DndAwitDXvKy4U

    Path: none

    Triage: unblocked · p3 · 2026-10-31T06:56Z

    ⛔ Not a claim.


    Generated by Claude Code

  5. objectstack-fleet commented on Oct 31, 2026

    @objectstack-fleet
    ContributorAuthor

    domain:skills#1 · os-tesla · session_01L9qibzCtJt8Q2Z63fyRNix

    Claim: skills seat 1 round 1 (fold chain head of #28256 #28246) · card thread · 2026-10-31T23:08Z
    Session: session_01L9qibzCtJt8Q2Z63fyRNix (the seat); card thread session_01L9qibvc9vjAiGhyhnLTp34
    Account: os-tesla (the seat's linked user; the card's assignee)
    Branch: claude/project-thread-w041mp
    Worktree: the card thread's own container checkout
    Domain: domain:skills
    Seat: domain:skills#1
    File surface: skills/objectstack-data/rules/field-types.md, skills/objectstack-data/evals/objects-fields-relationships.json (only if asked), content/docs/data-modeling/fields.mdx (lookup section), .changeset/28256-*.md. ⛔ No hooks-security-seeds-datasources.json, no references/_index.md. Stop on breach.
    Container & model: S, mode:thread, model: claude-fable-5-1 (MANDATORY by dispatch-gates.mjs --tier for this surface), effort high; contract-review tier before the queue; Tier H
    Clause-②: no
    Metadata-protocol: none
    Responsibility: n/a — not a defect card
    Thread-read: 6540335218
    Premise: holds (neither percentDisplay nor lookupAutofill is taught under skills/ or in fields.mdx on main 768ec4bf; the dev re-checks first)
    Ruling-ref: none; p3 under 「p3 也可以开发」
    Serial constraints cleared: open PR #28467 (another lane) touches skills/*/references/_index.md only, outside this surface; no other open PR or claim touches it
    Resume-from: none (fresh from origin/main)
    Order: /mnt/project-files/skills-seat-1/r2026-10-31/dispatch-data-fold-28256.md (project file)

    State: no state label (triage left it at p3 without pm:queue) → pm:dispatched, assigned to os-tesla, recorded by this claim.

  6. objectstack-fleet commented on Oct 31, 2026

    @objectstack-fleet
    ContributorAuthor

    domain:skills#1 · os-tesla · session_01L9qibvc9vjAiGhyhnLTp34
    os-dev-report

    Fold chain head #28256 (#28256 #28246) · draft PR #28487 · head 0984e3e9 · 2026-10-31T23:33Z

    {
      "issue": 28256,
      "status": "done",
      "branch": "claude/project-thread-w041mp",
      "pr": "https://github.com/objectstack-ai/objectstack/pull/28487",
      "session": "session_01L9qibvc9vjAiGhyhnLTp34",
      "premise_still_valid": true,
      "summary": "Fold of #28256 and #28246, one commit per card, draft PR #28487 at head 0984e3e9. #28256: the percent row of skills/objectstack-data/rules/field-types.md lists percentDisplay (unset or 'bar' draws the progress bar, 'plain' the number alone, for a rate or a probability), read against field.zod.ts:1597 and PercentCellRenderer (ui/packages/fields/src/index.tsx:978-988). #28246: the lookup and master_detail rows list lookupAutofill and one paragraph under the Relational table teaches the pair shape, single-value only, the target and source rules, the overwrite rule, client-side only and the grid autofill relation, read against field.zod.ts:2092-2110 and 2647-2667, object.zod.ts refuseDishonestLookupAutofill, stack.zod.ts collectLookupAutofillErrors, and the ui readers LookupField.fillDeclaredTargets, form.tsx onAutofill, GridField.lookupAutofillPatch; content/docs/data-modeling/fields.mdx (lookup section only, triage's one-PR exception) gains a property row, an example and a Lookup-pick autofill subsection with the rules in full, the source type table and the fully-authored master-detail bound PR #28322 asked this card to state. field-types.md sat at its 3207-token ceiling with zero headroom: paid by deleting Select with Default (dup of the Selection example), Email with Uniqueness (home rules/indexing.md unique scope), Lookup (Many-to-Many) (home SKILL.md; its max: 10 is the numeric bound, not a selection cap) and the vector paragraph (vectorConfig folded into the top invented-key list); no re-wrap. File 12826 to 12824 bytes, 3207 to 3206 tokens; bundle 163627 to 163625 bytes; every skills/*/SKILL.md unchanged. Changeset .changeset/28256-data-skill-percent-display-lookup-autofill.md, @objectstack/skills patch, Clause-②: no, Metadata-protocol: none. Tier H: the PR stays draft for the seat's contract review and the approver.",
      "tests": "Documentation only; no test files. Eval gate: `pnpm --dir ui run check:skill-eval-tokens --self-test` exit 0 (29 cases) and `pnpm --dir ui run check:skill-eval-tokens` exit 0 ('Every must_contain token is taught by its own skill bundle'). No eval case was asked, so skills/objectstack-data/evals/* is untouched. No ablation (no tested behaviour changed).",
      "gates": "Local subset at head 0984e3e9: `node scripts/pm/dispatch-gates.mjs --commands --repo objectstack-ai/objectstack` derived 67 families (docs gates included); each run with stdin closed after `turbo run build --filter='@objectstack/client-react...'` under the verify lock, exit codes recorded before any pipe; `--ran` reconciliation: '67 derived famil(ies) accounted for — 66 run, 1 NOT-MEASURED (1 DERIVED from a recorded exit 3)'. 66 exit 0, including check-skills-token-ratchet (+ --self-test; field-types.md 3206/3207), check:skill-identifier-liveness, check:corpus-claim-drift, check:doc-authoring, check:docs-spec-enumerations, check:doc-anchors, check:docs-single-h1, check:role-word, check:pm-skill-id-lint, check:pm-governed-merges, spec check:docs / check:liveness / check:skill-examples, check:closing-keyword-parity, check:empty-changeset, check:changeset-no-major. NOT MEASURED: pnpm check:dual-build-cjs-loads exit 3 (PREREQUISITE NOT MET, needs a full pnpm build; no package entry touched; CI runs it). Changed lines 112 (+66/-46, 3 files) under 3000. CI families: the PR's check-runs on #28487 are in_progress at report time; not re-run locally.",
      "dogfood_battery": "n/a — no `!` in the PR title and no (narrowing) arm",
      "mcp_calls": "11 — GitHub MCP READS only: issue_read get/get_comments on #28256 (x3) and #28246 (x2), issue_read get on #28255, pull_request_read get on #28322, #28244 and #28487; 0 write tools. The harness's assignee/reviewer MCP step was skipped (relay-only writes; the relay set no assignee by the order).",
      "api_writes": "3 — `git push -u origin claude/project-thread-w041mp` (not a REST write); relay pr_create via scripts/pm/fleet-write/dispatch.mjs (run 41252873660, read-back identical, PR #28487); this os-dev-report comment via scripts/pm/post-stamped.mjs --comment=28256. No labels sent (the order named none; not skip-changeset).",
      "open_questions": [],
      "out_of_scope_findings": [
        "class: none (observation, not a card) · the percent row's When-to-Use text 'Percentage values (0-100)' predates this card and does not state the storage rule (percentScaleOf: a fraction unless max is above 1); noted in the PR's acceptance notes · carrier: none · dedupe words: percent row storage, percentScaleOf skill"
      ]
    }
  7. objectstack-fleet commented on Nov 1, 2026

    @objectstack-fleet
    ContributorAuthor

    domain:skills#1 · os-tesla · session_01L9qibzCtJt8Q2Z63fyRNix

    Landed · 2026-11-01T03:53Z

    probe reading
    PR #28487 merged through the queue at 2026-11-01T03:48Z, merge commit 1f1a369b (enqueued by os-zhuang, Tier H; seat ACCEPT 6550937241, contract review PASS 6550923529)
    this card closed completed by the PR's Fixes line
    fold chain head of #28256 + #28246; #28489 (percent row storage scale, found by this PR's review) is the follow-up

    State: pm:dispatched removed (closed card).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

area:datadocumentationImprovements or additions to documentationdomain:skillsDomain lane — seat card indexed by label:pm:seatpriority:p3

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions