Skip to content

docs(adr): ADR-0078 and ADR-0087 note the conversion-conflict channel's retirement - #24046

Merged
os-zhuang merged 1 commit into
mainfrom
claude/issue-24001-adr-0078-note
Oct 17, 2026
Merged

os-zhuang merged 1 commit into
mainfrom
claude/issue-24001-adr-0078-note

Conversation

@objectstack-fleet

Copy link
Copy Markdown
Contributor

Part of #24001 — the governed half (Tier H). The code half is the companion draft PR #24045 on claude/issue-24001-conversion-conflict-retire, which carries Fixes #24001; this PR closes nothing.

What this changes

Three lines under docs/adr/, nothing else:

  • docs/adr/0078-no-silently-inert-metadata.md — one Amended 2026-10-16 (#24001), a citation retired — no decision changes line under Status: the ADR-0087 conversion layer's conflict channel, which cited this ADR's "never silent" rule for a flow-node rename refused over a live executor name, is retired with its last producer. Protocol 18 reserves the old callout node types (FLOW_RESERVED_NODE_TYPES), so the engine refuses such an executor at registration — this ADR's rule applied one step earlier. The completeness gate and every decision are unchanged.
  • docs/adr/0087-metadata-protocol-upgrade-contract.md — one dated note closing the 2026-08-02 addendum: the conflict guard that addendum and the 2026-07-31 / 2026-08-01 ones describe is gone, and with it reservedNodeTypes / onConflict, ConversionConflictNotice / ConversionConflictDetail, the conflicts arrays and 409 FLOW_CONVERSION_CONFLICT (D3 entry conversion-conflict-channel-removed). The historical text above it is left as recorded, per this repo's note-not-rewrite convention for ADRs.

Why separate: the claim keeps every docs/adr/** line out of the code PR, because one governed path makes the whole PR Tier H. The ADR-0087 registries (D2 conversions, D3 entries) live in code (packages/spec/src/conversions/, packages/spec/src/migrations/entries/), so the D3 entry rides the code PR.

Placement note: PR #23986 (#23903) also adds a dated note to ADR-0087, after the 2026-10-16 #23775 note (~line 575). This note sits at the end of the 2026-08-02 addendum (~line 711), a different gap, so the two merge clean in either order.

node scripts/check-adr-anchors.mjs on this branch: exit 0.

维护者速读(草稿)

改了什么:只在两份 ADR 里各加了一条带日期的注记。ADR-0078 状态行下加一行"引用退役、决策不变";ADR-0087 在 2026-08-02 附录末尾加一条注记,说明"转换冲突通道"已整体退役。没有改动任何已有的决策文字。

为什么改:#24001 的代码 PR 删除了"转换冲突"这一整套已发布接口(冲突通知类型、两个转换选项、conflicts 数组和 409 错误码 FLOW_CONVERSION_CONFLICT)。它唯一的触发来源——旧 HTTP 节点类型被第三方执行器占用时拒绝改名——在 #23543 F5-http 把三个旧名保留后已不可能发生。ADR 里仍描述着这条通道,读者(包括 AI)会以为它还存在,所以要留一条注记让文档跟上实现。

风险与代价(含回滚):纯文档,无运行时影响。回滚即删除这三行。唯一需要留意的是与 PR #23986 同改 ADR-0087,但插入位置不相邻,任一先合都不冲突。

席位意见:

你要做的:代码 PR 通过合同复核后,批准本 PR(Tier H 需授权人工批准);若希望注记措辞或位置调整,直接在评论里指出即可。

🤖 Generated with Claude Code

https://claude.ai/code/session_01WdZxJadrrYettvjrqiWeAV


Generated by Claude Code

@github-actions github-actions Bot added size/xs documentation Improvements or additions to documentation labels Oct 16, 2026
@objectstack-fleet

Copy link
Copy Markdown
Contributor Author

维护者速读 · PR #24046(Tier H,docs/adr/**)· domain:spec seat 2 · 2026-10-16T21:41Z

改了什么:两份 ADR 各加一条带日期的注记,共 +3 行,不改任何已有决策文字。

  • ADR-0078 状态行下加一行:"引用退役,决策不变"。
  • ADR-0087 在 2026-08-02 附录末尾加一条注记(:713):"转换冲突通道"已整体退役,并指向代码 PR 里的 D3 条目 conversion-conflict-channel-removed。

为什么改:#24001 的代码 PR #24045 删掉整套"转换冲突"已发布接口:

  • ConversionConflictNotice / ConversionConflictDetail;
  • onConflict / reservedNodeTypes 两个选项;
  • conflicts 数组;
  • 409 错误码 FLOW_CONVERSION_CONFLICT。

它唯一的触发来源是:旧 HTTP 节点类型被现存执行器占用时,拒绝改名。#23543 F5-http 把这三个旧名保留之后,这种情况已不可能发生。两份 ADR 仍在描述这条通道,读者(尤其是 AI)会以为它还在。注记让文档跟上实现。

风险与代价(含回滚):

席位意见:建议批准。

你要做的:批准 PR #24046。批准后由席位在 PR #24045 合并之后落地(ready + auto-merge)。

席位核对

Session session_01LFqdRsuM5nkqoJdHd5ztVk · os-bill. The reviewer of record, checked against GitHub rather than the report. The chain: claim 6222477086 (PR B named governed and kept separate), then report 6224904559.


Generated by Claude Code

@objectstack-fleet

Copy link
Copy Markdown
Contributor Author

Maintainer's word on the PR line · director seat (summon #43 continuation 3, session_01QJC7i981TSs9L1CGJK59Ax) · 2026-10-17T01:07Z


Generated by Claude Code

@objectstack-fleet objectstack-fleet Bot removed the needs-user-decision Blocked on a maintainer decision — do not dispatch; decision cards only, never on a PR label Oct 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation size/xs skip-changeset PR has no user-facing published change; bypasses the changeset gate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants