Repository navigation
refactor(pm): fleet-roster reads the mailbox constants from mailbox-open - #25506
Merged
Merged
Conversation
fleet-roster.mjs spelled pm:mailbox, its ledger exclusion and the mailbox/ branch prefix itself until mailbox-open.mjs reached main. It now imports all three from the opener, their one owner, and its self-test pins that the values are the opener's own (battery floor 12 -> 13). Co-authored-by: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LKHDniRQSWjRJyDtacwpEd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #25463
Clause-②: no
Metadata-protocol: none
What changed
scripts/pm/fleet-roster.mjsno longer declaresMAILBOX_LABEL,LEDGER_EXCLUSIONandMAILBOX_BRANCH_PREFIXitself. It imports them from./mailbox-open.mjs, their one owner since feat(pm): pm:mailbox label and the mailbox-open.mjs opener/closer (#25417) #25433 landed. Its own comment had asked for this ("once it lands, import them … and delete these").fleet-roster.mjs;git grepfinds no import of that file. So nothing is re-exported.Verification
node scripts/pm/fleet-roster.mjs --self-test→ 69 cases in 7 batteries pass.node scripts/pm/mailbox-open.mjs --self-test→ 40 pass.git grep -n "'pm:mailbox'" -- scripts/pm: the one declaration is inmailbox-open.mjs. The other hits are test fixtures.dispatch-gates --commands: 30 derived families, all exit 0;--ran→ 30 run, 0 NOT-MEASURED.scripts/pm. No changeset, because nothing is published (skip-changeset).Generated by Claude Code