fix(app-shell): the notify recipients editor writes and keeps { emailField } - #25996

Requested by Steve · project thread

Fixes #25900

Clause-②: no
Metadata-protocol: none

What changes

The Studio notify node's recipients editor (FlowRecipientsField) now knows the spec's fourth recipient form, the email-field recipient { emailField: 'FIELD' } (NotifyEmailFieldRecipientSchema, the whole recipients value, on a node whose only channel is email).

• Data loss closed. A stored recipients: { emailField } read as no recipients (readRecipients kept only strings and CEL envelopes), so the first edit of the node replaced it. It now reads as one Email field row, and an unedited row is written back as the object it was read from.
• An Email field row. Picks an email-typed field of the trigger object (the suggestions are filtered by field type) and stores { emailField: 'FIELD' } as the whole value. It is offered in the type select only while it is the sole row, and "Add recipient" is disabled beside it, so the editor never writes it as a list entry (which the spec refuses).
• Channels in the same patch. The commit that first stores an email-field recipient also writes channels: ['email'] when the node does not already name email alone (either spelling, string or list, counts). A blur that changes nothing writes no channel. A stored { emailField } on a node naming other channels shows a note and a one-click "Send by email only" fix.
• Record field row on a node that sends email. Where channels include email, the Record field picker no longer suggests email-typed fields: the runtime refuses the address that row's record.FIELD envelope evaluates to unless a user holds it (service-automation notify node, screenComputedAddresses). A stored Record field row over such a field keeps its value and says the address must belong to a user.

Where the fix lives, and one file beyond the card's list

• FlowRecipientsField.tsx — the row kind, read/write, notes.
• FlowReferenceField.tsx — ResolvedRef gains optional onlyFieldTypes / exceptFieldTypes for the object-field kind; resolveObjectName is exported so the recipients field reads the trigger object's field types.
• FlowNodeConfigField.tsx — onCommit takes an optional alongside map of sibling keys and the recipients case forwards it.
• FlowNodeInspector.tsx (declared to the seat as a file-surface addition) — setField applies alongside to the same node before the one patch. The write is the inspector's: two sequential setField calls each start from the node the render closed over, so the second would drop the first key.
• i18n.ts — en and zh strings for the new type, placeholder and notes.

Tests

New file FlowRecipientsField.emailField-25900.test.tsx, 11 tests: stored { emailField } round-trip and its row, Add disabled beside it, the Email field picker's suggestions and its commit (accepted by the installed NotifyConfigSchema, with channels), no channel write when the node already names email alone, not offered beside another row, the stored-wrong-channels note and fix, a non-email field named, the Record field filter on email and non-email nodes, and the inspector writing recipients and channels in exactly one patch.

• Before the fix (the new file against the unmodified editor): 10 failed, 1 passed (11). The data-loss pins failed on expected [] to deeply equal [ { kind: 'emailField', … } ] and expected null not to be null.
• After, at e25d3a6e: FlowRecipientsField* 2 files, 28/28 passed; the whole metadata-admin/ directory 597 files, 6561 passed, 1 skipped.
• Ablation (committed fix, scripts/ablation-replace.mjs, mutation landed anchor 1 -> 0, restored blob == HEAD, git diff HEAD empty): dropping the email-field arm from the readRecipients filter turns exactly the 5 stored-value tests red (11 → 6 passed), the write and filter tests stay green.
• pnpm --filter @object-ui/app-shell run type-check: exit 0 (the test program lists the new test file).

Gates

node scripts/pm/dispatch-gates.mjs --commands --repo objectstack-ai/objectstack at e25d3a6e derived 34 commands; all 34 exit 0, and --ran reconciles 34 derived, 34 run, 0 NOT-MEASURED (a derived zero, each line carrying its exit code). check:type-check-debt first returned queue-timeout (exit 3, nothing measured) and was re-run under the lock: OK. Type Check UI, Lint UI and Build & E2E UI are CI's.

Acceptance notes

• Channels editor reads a string as empty (not fixed here). The notify node's Channels field is the offline stringList editor, which reads a stored channels: 'email' string as an empty list; an edit there then writes a list without email. This PR writes channels as a list so the field shows it; a stored string spelling stays affected. Reported to the seat for filing.
• Lint on the touched files: 0 errors. Four new react-refresh/only-export-components warnings come from the new helper exports (isEmailFieldRecipient, readChannels, isEmailOnlyChannels, resolveObjectName), the same pattern as the helpers these files already export.
• A stored list that contains an { emailField } entry (which the spec refuses) is now kept as read instead of dropped; the spec's refusal names it.

Session: https://claude.ai/code/session_01VrsYtPiyNCyFG3fUsVvNEQ

Generated by Claude Code