Repository navigation
chore(ui-tooling): drop the dead turbo globalDependencies marker and three scripts nothing runs (slice 1 of #25920) - #26004
Merged
Conversation
…three scripts nothing runs - ui/turbo.objectui.json: `globalDependencies` named node_modules/@objectstack/spec/.spec-main-shape-gate.json, a marker only objectstack's spec injection wrote. The spec is a workspace package of this repository now and nothing writes it; the ci-cd-pipeline guide's "What stays here" bullet said otherwise and is rewritten. - ui/scripts/eval-console.mjs: a one-off Playwright probe writing to a hard-coded personal path; no alias, no workflow, no reference. - ui/scripts/release-bump.cjs: a manual version bumper superseded by the changesets release lane; no alias, no workflow, no reference. - ui/scripts/census-recorder-wait-shape.mjs with its test and fixtures: a hand-run census reachable only from its own test; nothing else names it. Co-authored-by: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012eXtKYmXEnCc1GExP4go12
Contributor
Author
席位核对Verdict: ACCEPT at head Checklist
Deletions checked against references (seat's own
Docs prose checked line by line (
Gates
Generated by Claude Code |
This was referenced Oct 26, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Elon · project thread
Part of #25920 — slice 1 of the unwired-tooling cleanup. The card stays open for the slices listed at the end.
Summary
Re-measured on
main05f7758 (after the objectui merge, so every card path reads with aui/prefix). Of the 68check:*/census:*names inui/package.json, 28 are run by no root workflow; 13 of those are still referenced from the inertui/.github/workflows(left to theui/.githubretirement), 1 is run by package build scripts, and the rest plus the test-only censuses come to about 25,000 lines of script and test. That is far over one PR, so this slice takes the dead turbo entry and the three files with no reference at all, at 1,485 changed lines (+5 / −1,480).Per item:
ui/turbo.objectui.jsonglobalDependencies→ delete the entry. It namednode_modules/@objectstack/spec/.spec-main-shape-gate.json, a marker only objectstack's spec injection wrote.@objectstack/specisworkspace:^in all 33 ui manifests now and nothing in the tree writes the marker (git grep spec-main-shapeoutside CHANGELOGs: only this entry, one test fixture path string, and the guide paragraph). The ci-cd-pipeline guide's "What stays here" bullet, which justified the entry, is rewritten.ui/scripts/eval-console.mjs→ delete. A one-off Playwright probe that writes to a hard-coded path on one developer's machine. No alias, no workflow, zero references.ui/scripts/release-bump.cjs→ delete. A manual version bumper the changesets release lane replaced. No alias, no workflow, zero references.ui/scripts/census-recorder-wait-shape.mjs+ its test +fixtures/census-recorder-wait-shape/→ delete. A hand-run census (its header: "answers WHERE TO LOOK, never WHAT IS WRONG"); no alias, no workflow, nothing names it but its own test.Nothing is wired in this PR: the triage comment on the card puts any new gate with the maintainer, so the gate-shaped scripts are listed below for a ruling instead.
Verification (head f7fda0f)
git grepacross the whole tree (AGENTS.md, skills, .claude, docs, every manifest) for each deleted file and alias: no hits outside the deleted files themselves. No governed text touched.dispatch-gates --commandsderived 18 families; all 18 run locally, all exit 0;--ranreconciliation: 18 derived, 18 run, 0 NOT MEASURED, 0 UNRUN.node scripts/check-ci-filter-parity.mjsexit 0 and--self-testexit 0;node scripts/pm/dispatch-gates.self-test.mjsexit 0.pnpm --dir ui run …gate commands rootci.ymlruns: 43 exit 0 (check:spec-symbols,check:action-forward-parity,check:designer-field-key-parityandtype-check:scriptsfirst ran beforepackages/spec/distexisted and are green on a re-run after it was built). The other 7 (check:doc-examples,check:doc-json,check:doc-snippets,check:readme-exports,check:skill-examplesand its--self-test,type-check:vitest-setup) stop on unbuilt@object-ui/*dist/(each prints the missing path): NOT MEASURED locally, CI's Lint UI / Type Check UI lanes own them. None of their output names a deleted file.check:commit-card-trailers --range origin/main..HEADgreen.files[]changes (ui scripts, the parked turbo config and a guide page).Remaining slices (numbers are script + test lines on 05f7758)
Delete candidates — report-only instruments no gate reads:
coverage-red-cause-census.mjs+coverage-red-cause-suspects.jsonmarkdown-test-inputs.mjsrowextract-mdx-demos.mjstsconfig-test-parity-census.mjs(census:tsconfig-test-parity)ui/docs/audits/2026-09-test-tsconfig-parity-census.md; those pointers move with itpage-key-read-census.mjs(census:page-key-reads)dollar-dialect-alias-census.mjs(census:dollar-dialect-aliases)changeset-polarity-census.mjs(census:changeset-polarity)check-component-surface-parity.mjs(check:component-surface-parity)cli,objectui,doctor,studio,generate,g),start,site:start,test:unit,test:integrationbuild:allis already goneGate-shaped (exit 1 on a breach) — wire-or-delete is a maintainer ruling per the card's triage:
check-lint-rule-coverage.mjscheck-unused-dependencies.mjscheck-registry-bare-name-collisions.mjscheck-comment-mask-corpus.mjs+ test-onlycheck-hand-rolled-comment-mask.mjscheck-ui-root-lookups.mjscheck-pending-changeset-literals.mjsbody-dialect-census.mjs/body-dialect-producer-scan.mjs(ruling objectui#6771 calls the liveness reading a hard gate; imported by other scripts)Kept:
check:dist-completeness(run by 14 packagebuildscripts);cross-file-line-citation-census.mjs(library of the line-citation gate). Left to theui/.githubretirement (referenced only byui/.github/workflows):check:i18n-dead-keys,check:node-esm-load,check:published-dist,check:eager-closure,check:eager-locale-catalogues,check:sdui-registration-pins,check:governed-queue-guard,check:merge-queue-head,check:required-check-set,check:lockfile-integrity,check:lockfile-dedupe,check:changeset-claims,check:new-line-citations.Later slice under this dispatch: the mechanical tsconfig dedupe. Not in this dispatch: the dedupe-wrapper swap (a workflow change), the vite factory, the UMD condition.
Acceptance notes
spec-shape-gate.ymlhourly runs that no longer exist in this repository; only the bullet this diff falsified is rewritten here.Generated by Claude Code
🤖 Generated with Claude Code
https://claude.ai/code/session_012eXtKYmXEnCc1GExP4go12