fix(console): the approvals inbox names the flow, the step and the object in the reader's language - #27040

Requested by Warren · project thread
Fixes #26883

Clause-②: no
Metadata-protocol: none

维护者速读

• 改了什么:审批收件箱的所有审批接口调用改走控制台的认证 fetch(和申请详情页同一条通道),请求带上用户选择的界面语言;对象筛选下拉显示对象标签而不是机器名。
• 为什么改:服务端审批接口早已按 Accept-Language 从应用语言包翻译流程/步骤/对象标签,但收件箱用裸 fetch,只带浏览器语言,所以中文用户在收件箱看到英文。
• 风险与回滚:低;只换了传输层(额外带上 X-Tenant-ID 与界面语言头,和详情页一致),回滚即还原 approvalsApi.ts 的 call。
• 先看:ui/apps/console/src/services/approvalsApi.ts 的 call;ApprovalsInboxPage.tsx 的 objectOptions;新测试 ApprovalsInboxPage.readerLocaleLabels-26883.test.tsx。
• 两分钟验证:pnpm --dir ui exec vitest run apps/console/src/pages/system/ApprovalsInboxPage.readerLocaleLabels-26883.test.tsx,预期 6 个全过。
• 需要你做的:无,席位落地;Setup › 审批申请 列表那一半走服务端,另立卡(见 Acceptance notes)。

What changes

• approvalsApi.call (every inbox read and decision) now goes through createAuthenticatedFetch() from @object-ui/auth, the transport approvalRequestsDataSource.ts (the request page) already uses. It stamps the Bearer (as before), X-Tenant-ID, and the active UI language as Accept-Language. The hand-built Bearer header is gone because the wrapper sets it.
• The approvals door already serves process_label, step_label and object_label in the request's Accept-Language from the app's pack (flows.FLOW.label, flows.FLOW.approvals.NODE.label, objects.OBJECT.label; reader-locale-labels.ts in @objectstack/plugin-approvals, shipped in 18.1.0), keeping the stored label when the pack has no entry. So the row, the process filter and the object column now show the pack's text with no client-side resolver.
• Bounded in-place fix, same defect class and same file: the inbox's object filter listed machine names (opportunity); it now lists each object by the label the row serves, and the search haystack includes object_label.
• Changeset: @object-ui/console patch.

Why

The card's mechanism assumption (the inbox shows the stored English with no lookup, fix by a client lookup) is disproved on origin/main 5e99bd93: the server translates per reader, and the inbox simply never told it the reader's language. A bare fetch sends only the browser's language, so a zh-CN user on an en-US browser got English. Same root cause and same fix shape as the /forms/:name select-option fix (.changeset/26452-form-options-locale.md). No second resolver, nothing stored changes, no server change.

Tests

New ui/apps/console/src/pages/system/ApprovalsInboxPage.readerLocaleLabels-26883.test.tsx: the real I18nProvider writes the html element's lang attribute, the real createAuthenticatedFetch reads it, and a global fetch stand-in for the door answers in the language it is asked for.

• the inbox asks the door with Accept-Language: zh under a zh UI;
• the queue row shows 大额商机审批 / 销售经理审核 / 商机, not the English;
• a flow the pack does not cover keeps its stored labels;
• the process and object filters list the shown labels;
• search matches the shown text and the machine name;
• control: an English UI reads the stored English.

Acceptance notes

• Out of scope, list half: Setup › Approval Requests is the generic sys_approval_request object list (nav_approval_requests in approvals-plugin.ts), read over the generic data door, which serves the stored process_label / current_step_label (the reader-locale-labels.ts header says so). The fix lands server-side in @objectstack/plugin-approvals, not in plugin-list / plugin-grid, filed as Setup › Approval Requests list shows the stored flow and step labels under zh-CN: the data-door read of sys_approval_request skips the reader-locale labels the approvals door applies #27041.
• Premise drift: the inbox's detail sheet named in the dispatch was deleted earlier; opening a request goes to the served request page, which already reads through the authenticated fetch.
• Search: the stored English is no longer on the wire for a translated row, so search matches the shown (translated) text and the machine names, not the stored English.

Verification

node scripts/check-adr-0087-registration.mjs --base origin/main :: exit 0
node scripts/check-adr-0087-registration.mjs --self-test :: exit 0
node scripts/check-changeset-no-major.mjs --base origin/main :: exit 0
node scripts/check-closing-keyword-parity.mjs :: exit 0
node scripts/check-closing-keyword-parity.mjs --self-test :: exit 0
node scripts/check-comment-mask-corpus.mjs :: exit 0
node scripts/check-empty-changeset.mjs --base origin/main :: exit 0
node scripts/check-empty-changeset.mjs --self-test :: exit 0
node scripts/check-sdui-manifest.mjs :: exit 0
node scripts/check-sdui-manifest.mjs --self-test :: exit 0
node scripts/pm/release-rehearsal-clone.mjs --self-test :: exit 0
node scripts/release-pending-publish.mjs --self-test :: exit 0
pnpm --dir ui exec vitest run scripts/ :: exit 0
pnpm --filter @objectstack/spec run check:duration-unit-keys :: exit 0
pnpm check:changeset-gate-self-tests :: exit 0
pnpm check:closed-ceremony-text :: exit 0
pnpm check:cross-package-test-inputs :: exit 0
pnpm check:dispatcher-error-vocabulary :: exit 0
pnpm check:driver-memory-census :: exit 0
pnpm check:engine-double-contract :: exit 0
pnpm check:gitlink-declared :: exit 0
pnpm check:nul-bytes :: exit 0
pnpm check:pm-changeset-deadline-census :: exit 0
pnpm check:published-files :: exit 0
pnpm check:query-options-erasure :: exit 0
pnpm check:refd-timer-probe :: exit 0
pnpm check:test-source-alias :: exit 0
pnpm check:tier-file-adoption :: exit 0
pnpm check:type-check-coverage :: exit 0
pnpm check:type-check-debt :: exit 0
pnpm check:undeclared-dep-imports :: exit 0
pnpm check:watch-hint-literal :: exit 0
pnpm check:where-matcher :: exit 0

Human Minimum

• 1. Schemas start as Zod; packages/spec holds no runtime logic.
• 2. Every name I added uses the casing for its kind.
• 3. No formatter ran; pnpm lint passes (CI-owned).
• 4. One issue, one branch off an up-to-date main, one pull request.
• 5. A change that publishes carries a changeset, and both declaration lines are filled in here and in the changeset.
• 6. packages/spec not touched.
• 7. No hand edits to content/docs/references/, packages/*/CHANGELOG.md or content/docs/releases/.
• 8. Title, body and comments are in English.
• The Before Submitting list in CONTRIBUTING.md is done.

🤖 Generated with Claude Code

Generated by Claude Code