Skip to content

docs(qa): approvals checklist reads a paused run's variables; deep-link APP is com.objectstack.setup - #27164

Merged
objectstack-fleet[bot] merged 1 commit into
mainfrom
claude/issue-25807-wave2-accuracy-d
Oct 28, 2026
Merged

objectstack-fleet[bot] merged 1 commit into
mainfrom
claude/issue-25807-wave2-accuracy-d

Conversation

@objectstack-fleet

Copy link
Copy Markdown
Contributor

Part of #25807 (wave-2 accuracy, slice D)
Clause-②: no
Metadata-protocol: none

维护者速读

What changes

One file, two items, each revision +1 from main with main's history kept as an exact prefix and one appended row citing #27134.

approvals.dynamic-approver-routing r4 → r5

approvals.notification-deep-link r8 → r9

  • steps[3]: on the bare /system/approvals route, APP is com.objectstack.setup. requestPagePath (ApprovalsInboxPage.tsx) falls back to the setup app's name setup. The app shell's canonicalAppPathname (ui/packages/app-shell/src/utils/appRoute.ts) then replaces that name alias with the package id SETUP_APP_PACKAGE_ID (packages/apps/setup/src/index.ts). QA run · area:approvals slice-C ids (5/5) · 07d18e69 · 2026-10-28 · 5 PASS / 0 PARTIAL / 0 FAIL / 0 BLOCKED / 0 NOT-RUN #27134 measured this live.
  • acceptance[3]'s verify parenthetical had the same stale setup, and it gets the same correction. Every clause still uses the APP placeholder, so no assertion changes.

Acceptance notes

Verification

Local gates at HEAD bf4b3b8 (each exit captured before any pipe)
  • node scripts/check-platform-checklist.mjs → exit 0, OK — 16 areas, 329 items (324 active, 1 planned); symbol anchors 1036/1046 resolved, 10 on the named residual
  • node scripts/check-platform-checklist.mjs --self-test → exit 0, 265 assertions
  • node scripts/checklist-select.mjs area:approvals → exit 0, 20 runnable items, both edited items included
  • node scripts/pm/dispatch-gates.mjs --commands --repo objectstack-ai/objectstack → exit 0, 16 commands. All 16 were run and exited 0. check:doc-formula-expressions first answered exit 3 (PREREQUISITE NOT MET: lint/formula not built). After turbo run build --filter=@objectstack/formula --filter=@objectstack/lint (VERDICT command-exit 0), it answered exit 0.
  • --ran → exit 0, 16 derived famil(ies) accounted for — 16 run, 0 NOT-MEASURED (a DERIVED zero)

Generated by Claude Code

…nk APP is com.objectstack.setup

approvals.dynamic-approver-routing (r5): a paused run's detail carries
its variables snapshot (#7639), measured live in QA run #27134, so the
vars clause gains a snapshot leg on the stage-2-paused run beside the
kept resolution leg; knownGaps[0], steps[7] and source[3] follow.

approvals.notification-deep-link (r9): steps[3] and acceptance[3]'s
verify name the bare-route landing segment com.objectstack.setup, as
measured in #27134 (requestPagePath falls back to the name 'setup';
the app shell rewrites the alias to the package id).

Claude-Session: https://claude.ai/code/session_01QSeKYmP1ZLg3jhTNud1E3J
Co-authored-by: Claude <noreply@anthropic.com>
@objectstack-fleet objectstack-fleet Bot added the skip-changeset PR has no user-facing published change; bypasses the changeset gate label Oct 28, 2026
@objectstack-fleet

Copy link
Copy Markdown
Contributor Author

席位核对 — ACCEPT · domain:devx#2 · head bf4b3b88be · 2026-10-28T09:12Z

席位意见:合入。按实测运行记录 #27134 修正两个审批条目:dynamic-approver-routing 的 vars 条款改为直接读暂停中 run 的 variables(加强,不是放宽);notification-deep-link 的 APP 段改为实测的 com.objectstack.setup。账本规矩守住,CI 全绿,非受管面。

Shape: draft → main. Part of #25807 (wave-2 accuracy, slice D). Label skip-changeset, assignee os-justin. 1 file, +14/−12. Report: os-dev-report 6464857194.

Seat's own read:

Deviation accepted: the same stale fact also sat in steps[7]/source[3] and in acceptance[3].verify of the two items. The dev corrected it there too, so neither item contradicts itself. This stays inside the two items the claim named.

Gates: at head bf4b3b88be, 46 check-runs: 27 success, 19 skipped, 0 failure. check-expected-skips: OK. Not governed.

Open question: A. The new stage-2 key variables['lead_review.next_reviewers'] comes from source and has not yet been read live. The next scheduled approvals run confirms it. A mismatch reds loudly, and the history row says no prior verdict carries.

Landing: non-governed. Ready + auto-merge now.


Generated by Claude Code

@objectstack-fleet
objectstack-fleet Bot marked this pull request as ready for review October 28, 2026 09:14
@objectstack-fleet
objectstack-fleet Bot enabled auto-merge October 28, 2026 09:14
@objectstack-fleet
objectstack-fleet Bot added this pull request to the merge queue Oct 28, 2026
Merged via the queue into main with commit 6535457 Oct 28, 2026
47 checks passed
@objectstack-fleet
objectstack-fleet Bot deleted the claude/issue-25807-wave2-accuracy-d branch October 28, 2026 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/s skip-changeset PR has no user-facing published change; bypasses the changeset gate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants