fix(studio): hold a Rollup field until it is set up, and offer only the child fields the spec accepts for its function - #27720

Requested by Bill · project thread

维护者速读

• 改了什么：Studio 数据页新加「汇总（Rollup）」字段时，在子对象、汇总方式、（sum/avg/min/max 时的）汇总子字段配齐之前不再自动保存草稿，页面上出现一行提示点名字段和还缺的那一项，带「Show me」；「汇总的子字段」下拉只列出 spec 规则接受的子字段（选 Sum 不再出现文本、审计、lookup、主从字段）。
• 为什么改：以前一点 Create 就把 { type: 'summary' }、没有 summaryOperations 的字段写进草稿，服务端照收，这个字段处处读 0；子字段下拉不按汇总方式过滤，作者能选出运行时拒收的组合。
• 风险与回滚：只改前端的拦截判定与下拉候选，判定全部问 spec（checkFieldCompleteness、FieldSchema、isAggregateCompatibleWithFieldType），不另存类型清单；最坏情况是多拦一次（提示行 + Show me 可解）。回滚即 revert 本 PR。
• 先看：ui/packages/app-shell/src/views/studio-design/metadataError.ts（summaryHeldInput / summaryHeldEdit）、ui/packages/app-shell/src/views/metadata-admin/inspectors/ObjectFieldInspector.tsx（aggregandOptions）、DataPillar.summaryHeld-27461.test.tsx。
• 两分钟验证：pnpm --dir ui exec vitest run packages/app-shell/src/views/studio-design/metadataError.summaryHeld-27461.test.ts packages/app-shell/src/views/metadata-admin/inspectors/ObjectFieldInspector.summaryAggregand-27461.test.tsx packages/app-shell/src/views/studio-design/DataPillar.summaryHeld-27461.test.tsx，预期 3 个文件 13 条全部通过。
• 需要你做的：无，席位落地。

Fixes #27461

Clause-②: no
Metadata-protocol: none

What changes

Held half (card steps 2 to 4). The Data pillar's autosave already holds an edit the object write guard would refuse (a choice field before its options, a relationship before its target). The guard lets a roll-up through at every stage, and the server saves a summary with no summaryOperations (it reads 0 everywhere), so the card's draft PUT went out the moment the field was created. objectHeldEdit now also holds the first named summary field that is still being set up, once the guard lets the fields through and before an unfinished action:

• The judges are the spec's own, never a list kept here: its completeness rule field/summary-without-operations (checkFieldCompleteness, @objectstack/spec/kernel) for a roll-up with no summaryOperations, and FieldSchema for what a started one still lacks. Unfinished means every issue FieldSchema names under summaryOperations is the child object, the function, or the child field (which the schema requires exactly when summaryFunctionReadsField says the function reads one), each still absent. Any other issue (an unknown function, say) is finished but wrong: the save is sent and its refusal shows as before.
• The held line names the field by its label and the input it needs, in the inspector's order, with the inspector's own label (Child object, Aggregation, Child field to aggregate). "Show me" reopens the field. The Studio Publish refusal and the held-edit report read the same objHeld, unchanged.
• One new clause, engine.studio.held.fieldNeedsInput (en, zh): the existing needsOptions / needsTarget / step / action / widget clauses do not name a field input.

Picker half (card steps 5 to 7). "Child field to aggregate" now offers only the child fields isAggregateCompatibleWithFieldType (@objectstack/spec/data, the aggregate × field-type table the dataset compiler and the engine's aggregate door read) accepts for the chosen function. Before a function is picked, it offers a field some value-reading summary function accepts. The filter rows keep offering every child field: a filter reads any.

Tests

• New metadataError.summaryHeld-27461.test.ts (8 cases): each held case is paired with the spec's verdict on the same field (the completeness rule fires, or FieldSchema refuses at that path); controls: a count without a field and a sum with one are accepted by the spec and not held, an unknown function is sent, and a choice field the guard refuses is named first.
• New ObjectFieldInspector.summaryAggregand-27461.test.tsx (3 cases): the card's child object (text, textarea, datetime, lookup, master_detail, number, percent, boolean, formula); for each of sum, avg, min, max the picker offers exactly what the rule accepts, and before a function, the union.
• New DataPillar.summaryHeld-27461.test.tsx (2 cases): the card's path (Form tab, Add field, Label "Child Count", Type Rollup, Create) sends no PUT past the debounce and names the child object; after the child object it names the aggregation and still sends nothing; picking Count sends one PUT with { object, function: 'count' } and clears the line. "Show me" reopens the closed field.

Readings below are on the final head 6f387b30 (this branch merged with origin/main at e35db835) unless a line says otherwise.

pnpm install --frozen-lockfile :: exit 0
pnpm --filter '@object-ui/app-shell^...' build :: exit 0
pnpm --filter @object-ui/app-shell run type-check :: exit 0
pnpm --filter @object-ui/i18n run type-check :: exit 0
vitest: the three new suites, DataPillar.heldIncomplete-11786, metadataError.heldEdit-11786, ObjectFieldInspector.test :: Test Files 6 passed (6) · Tests 80 passed (80)

node scripts/check-adr-0087-registration.mjs --base origin/main :: exit 0
node scripts/check-adr-0087-registration.mjs --self-test :: exit 0
node scripts/check-changeset-no-major.mjs --base origin/main :: exit 0
node scripts/check-closing-keyword-parity.mjs :: exit 0
node scripts/check-closing-keyword-parity.mjs --self-test :: exit 0
node scripts/check-comment-mask-corpus.mjs :: exit 0
node scripts/check-empty-changeset.mjs --base origin/main :: exit 0
node scripts/check-empty-changeset.mjs --self-test :: exit 0
node scripts/check-sdui-manifest.mjs :: exit 0
node scripts/check-sdui-manifest.mjs --self-test :: exit 0
node scripts/pm/release-rehearsal-clone.mjs --self-test :: exit 0
node scripts/release-pending-publish.mjs --self-test :: exit 0
pnpm --dir ui exec vitest run scripts/ :: exit 0
pnpm --filter @objectstack/spec run check:duration-unit-keys :: exit 0
pnpm check:changeset-gate-self-tests :: exit 0
pnpm check:closed-ceremony-text :: exit 0
pnpm check:cross-package-test-inputs :: exit 0
pnpm check:dispatcher-error-vocabulary :: exit 0
pnpm check:driver-memory-census :: exit 0
pnpm check:engine-double-contract :: exit 0
pnpm check:gitlink-declared :: exit 0
pnpm check:nul-bytes :: exit 0
pnpm check:pm-changeset-deadline-census :: exit 0
pnpm check:published-files :: exit 0
pnpm check:query-options-erasure :: exit 0
pnpm check:refd-timer-probe :: exit 0
pnpm check:skill-identifier-liveness :: exit 0
pnpm check:test-source-alias :: exit 0
pnpm check:tier-file-adoption :: exit 0
pnpm check:type-check-coverage :: exit 0
pnpm check:type-check-debt :: exit 0
pnpm check:undeclared-dep-imports :: exit 0
pnpm check:watch-hint-literal :: exit 0
pnpm check:where-matcher :: exit 0

Acceptance notes

1. Booleans are offered for Sum, Avg, Min and Max. The card expected "only numeric child fields"; the triage ruled the picker reads the spec's rule and keeps no second list, and that rule accepts the boolean class in all four rows (booleans aggregate as numbers on every backend). Min and Max also accept the temporal class, and Sum refuses percent while Avg accepts it. The picker follows the rule as written.
2. No inspector hint for a held roll-up. A held choice or relationship field also shows a hint under its input in the inspector (designer.field.hint.addOption / pickTarget); a held roll-up shows the held line only. The acceptance asks for the held line and "Show me", which this delivers; an inspector hint would be a new string beside a different input per stage, left out of this card.
3. A field already stored on a roll-up stays as it is. If a stored summaryOperations.field names a child field the rule refuses for the function (for example after switching Sum to Max), the picker no longer lists it but the stored value is not rewritten; the server's diagnostics remain the judge of a finished roll-up.
4. Attribution line 2 links this card thread, the block the harness requires, rather than the seat thread link the dispatch order quoted.

Verification

Run the three new suites (command in 维护者速读). In a running Console: Studio, Data, a parent object, Form, Add field, Label "Child Count", Type Rollup, Create: no draft PUT goes out and the line "Not saved yet: Child object on the field “Child Count” needs a value. …" appears; set Child object and Aggregation = Sum, then open "Child field to aggregate": only the child's number (and boolean) fields are listed.

Generated by Claude Code