Skip to content

fix(platform-objects): name each Setup settings entry as the hub does; label notification and audit options - #28062

Merged
objectstack-fleet[bot] merged 3 commits into
mainfrom
claude/project-thread-9z96wv
Oct 30, 2026
Merged

fix(platform-objects): name each Setup settings entry as the hub does; label notification and audit options#28062
objectstack-fleet[bot] merged 3 commits into
mainfrom
claude/project-thread-9z96wv

Conversation

@objectstack-fleet

@objectstack-fleet objectstack-fleet Bot commented Oct 30, 2026

Copy link
Copy Markdown
Contributor

Requested by Elon · project thread

domain:server#4 · os-elon-musk · session_016WV4cxh364AJYtdpWoPiHV

Fixes #27854
Refs #27855

Clause-②: no
Metadata-protocol: none

维护者速读

What changes

Setup sidebar ↔ settings hub (#27854). One name per settings page, one set of pages.

  • setup-nav.contributions.ts: nav_settings_mail is labelled "Mail Delivery" (was "Email"). New entries nav_settings_sms ("SMS Delivery", after mail) and nav_settings_lifecycle ("Data Lifecycle", after Knowledge), both requiredPermissions: ['manage_platform_settings'], the read permission of their namespaces.
  • Translations (apps/translations/{en,zh-CN,ja-JP,es-ES}.ts): each settings entry takes the hub card's title in that locale. zh-CN / ja-JP: company 公司信息 / 会社情報 → 公司 / 会社, mail 邮件 / メール → 邮件投递 / メール配信. es-ES: mail Correo → Envío de correo, storage and feature flags take the hub's wording. The two new entries are translated; the lifecycle wording reuses the object form's existing "Data Lifecycle" term in each locale. The mail entry's recorded source hashes are refreshed with its re-translation (the en source changed), and the two new entries record theirs.
  • Drift pin, packages/services/service-settings/src/setup-nav-hub-parity.test.ts (it lives there because service-settings depends on platform-objects, so the reverse import would be a cycle). It boots SettingsServicePlugin with the bundled manifests, registers lifecycleSettingsManifest the way ObjectQLPlugin does, folds the Setup tree through the real registry (so the Branding entry this package contributes counts), and asserts: every hub namespace has exactly one sidebar entry and no entry opens an unlisted page; the en label equals the hub title; each translated locale's label equals the hub's translated title wherever the hub has one; and the namespaces with no translated hub title are exactly ['lifecycle'].

Notification Events and the audit action (#27855, partly).

  • audit/sys-notification.object.ts: severity options are labelled Info / Warning / Critical over the same info / warning / critical values. source_object declares widget: 'object-ref' (the sharing-rule pattern), so the console draws the object's label; the field stays text and nothing but NotificationService writes it (apiMethods: ['get', 'list']).
  • plugin-audit/src/objects/sys-audit-log.object.ts: every action option carries a label ("Config Change", "Login Failed", …), stored values unchanged. The "Audit Events by Action" chart reads these: resolveDimensionLabels (@objectstack/service-analytics) resolves a dimension through the field's options whatever the dimension's type, so system.datasets.ts needs no change. The bare-array Field.select shorthand had made each label the code; zh-CN / ja-JP / es-ES already carried words, only en showed codes.
  • Regenerated: platform-objects/src/apps/translations/en.objects.generated.ts (severity), plugin-audit/src/translations/en.objects.generated.ts (action), by node scripts/check-i18n-bundles.mjs --write; no translated-locale value moved.

Not in this PR.

Why

Every administrator in Setup saw one page under two names, could not reach SMS Delivery or Data Lifecycle from the sidebar, and read raw codes on System Overview and Notification Events.

Verification

Measured on main 5aee2065 (sidebar vs hub, all four locales): en mail "Email" vs "Mail Delivery"; sms and lifecycle had no sidebar entry; zh-CN and ja-JP company and mail, and es-ES mail, storage and feature flags, differed from the hub. severity options were { label: 'info', value: 'info' }…; sys_audit_log.action labels equalled their values.

Pins, red first on main and green on this head:

  • service-settings/src/setup-nav-hub-parity.test.ts: 6 of 9 red on main (non-vacuity, set equality missing: [sms, lifecycle], en, zh-CN, ja-JP, es-ES label drift), 9/9 green.
  • platform-objects/src/audit/sys-notification-display-labels.test.ts: object file restored from main → 2 red; restored → green.
  • plugin-audit/src/objects/sys-audit-log-action-labels.test.ts: object file restored from main → the label case red, the stored-values case green (the values never moved); restored → green.

Suites: @objectstack/platform-objects 101 files / 1434 tests, @objectstack/plugin-audit 66 files / 1053 tests, @objectstack/service-settings 63 files / 1025 tests pass; typecheck of all three passes; pnpm check:i18n, check:i18n-coverage, check:i18n-stale-fill pass. dispatch-gates --commands derived 61 families at f3487c44: 60 exit 0, check:dual-build-cjs-loads NOT MEASURED (exit 3, needs every package's dist); pnpm lint exit 0.

Skills-docs: none — the docs name these pages as "Setup → Settings → SMS Delivery", which still holds.

Human Minimum

  • 1. Schemas start as Zod; packages/spec holds no runtime logic.
  • 2. Every name I added uses the casing for its kind.
  • 3. No formatter ran; pnpm lint passes.
  • 4. One issue, one branch off an up-to-date main, one pull request.
  • 5. A change that publishes carries a changeset, and both declaration lines are filled in here and in the changeset.
  • 6. packages/spec touched: not touched.
  • 7. No hand edits to content/docs/references/, packages/*/CHANGELOG.md or content/docs/releases/.
  • 8. Title, body and comments are in English.
  • The Before Submitting list in CONTRIBUTING.md is done.

🤖 Generated with Claude Code

https://claude.ai/code/session_016WV4cxh364AJYtdpWoPiHV

claude added 2 commits October 30, 2026 10:43
@claude
wip: align Setup sidebar settings entries with the hub; label notific…
4c184c5 
…ation and audit options

Claude-Session: https://claude.ai/code/session_016WV4cxh364AJYtdpWoPiHV
Co-authored-by: Claude <noreply@anthropic.com>
@claude
fix(platform-objects): name each Setup settings entry as the hub does…
f3487c4 
…; label notification and audit options

The Setup sidebar now carries each settings page's hub title in every shipped
locale and lists SMS Delivery and Data Lifecycle, pinned against the registered
manifests in service-settings. Notification severity reads Info / Warning /
Critical, Source Object is drawn as the object's label, and every audit action
option carries a label; stored values are unchanged.

Claude-Session: https://claude.ai/code/session_016WV4cxh364AJYtdpWoPiHV
Co-authored-by: Claude <noreply@anthropic.com>
@github-actions github-actions Bot added size/m documentation Improvements or additions to documentation tests tooling Fix lands in tooling, not a product package — enters pm:queue only with Unblocks: or a named surface labels Oct 30, 2026
@github-actions

github-actions Bot commented Oct 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

📓 Docs Drift Check

This PR changes 2 package(s): @objectstack/platform-objects, @objectstack/plugin-audit, touching 16 documentable anchor(s).

16 hand-written doc(s) name something this change touched — list omitted above 15 rows. Re-derive on the tree named below: node scripts/docs-audit/affected-docs.mjs --json 2e955dde6c058e629a439714695667184f5cb783.

⛔ 12 release-owned page(s) also affected — read-only, see AGENTS.md Documentation Guardrails.

What this run could not see
  • 1 name(s) were too generic to anchor anything (single lowercase words)
  • the SDK route bridge reached 58 of 210 client-bound route-ledger rows — the other 152 have no registrar path: tail to select them, so pages documenting THEIR client methods cannot appear above, on this or any run. Of those 152: 0 are remediable by widening that discovery convention (an in-repo file declares the path; the convention did not scan it); 55 are structural — on a ledger where NOT ONE row is declared in-repo, so no discovery change reaches them at any price; 97 are undecided (no in-repo declaration, on a ledger that has other in-repo registrars — absence and an unreadable spelling are not distinguishable here). The rows themselves: node scripts/docs-audit/affected-docs.mjs --bridge-coverage
  • a page that states a rule by its inputs shares no identifier with the emitter that implements the rule, so an emitter-only diff cannot list it — not on this run and not on any run. Measured on fix(driver-sql): emit varchar(maxLength) for a text field a declared index keys on #11430: content/docs/protocol/objectql/types.mdx documents the text-family column mapping by the ObjectQL type names it maps FROM (text / textarea / html) while the diff changed createColumn; it went unlisted, and it was the page that diff falsified, in four places. No shared token exists to detect this on, so a rule your change carries has to be re-read by hand in the pages that restate it.
  • a key NAME is not a key, so the hand re-read the line above prescribes can land on the wrong schema. The same spelling is authorable on one governed type and a [REMOVED] tombstone on another for each of active, aria, joins, objects, template, tools and version (censused on [finding] tools is a key on BOTH AgentSchema (tombstoned, dead) and SkillSchema (live, cloud-attested), so a name-based search attributes skill examples to the agent key — it produced a false stop-the-line alarm on PR #19059 #19093 over the liveness ledger's governed types, top-level keys); nothing in a search result distinguishes the two, so a grep hit on a LIVE example reads as evidence about the DEAD key. Measured on fix(spec): the agent.tools liveness row says dead — it claimed live on a key the schema tombstoned #19059: content/docs/ai/agents.mdx was reported as contradicting the agent.tools tombstone over its tools: example at :161, which is inside the defineSkill({ block opened at :155 — the page was already correct. Settle ownership by PARSING the value against both schemas, never by the name: that literal PASSES SkillSchema, and as an AgentSchema it FAILS at tools with the tombstone prescription. ⛔ These names are not the whole class — a key retired through a .strict() guidance map leaves no tombstone in the walked shape and none of them here (tool.category, live as AIToolDefinition.category).

Coarse fallback — 11 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): node scripts/docs-audit/affected-docs.mjs --json 2e955dde6c058e629a439714695667184f5cb783 → packageMentionDocs.

Which tree this was computed on

This run read content/docs from ab8dc9a9e54a8515b84d2cde4f2e9329660c2f3b — the merge of head 8037b1c346eb35e4e6b367e1b9b8a8aca43d1fe5 into base 2e955dde6c058e629a439714695667184f5cb783, which is what actions/checkout gives a pull_request run. Not the PR head.

A worktree cut from an older main holds a different content/docs, so re-deriving there can legitimately return a different list — that is a different tree, not a wrong row. To answer on the same tree:

# while this PR is open — GitHub drops the merge commit once it closes
git fetch origin ab8dc9a9e54a8515b84d2cde4f2e9329660c2f3b && git checkout ab8dc9a9e54a8515b84d2cde4f2e9329660c2f3b
# afterwards, rebuild it from the two parents, which stay fetchable
git fetch origin 2e955dde6c058e629a439714695667184f5cb783 8037b1c346eb35e4e6b367e1b9b8a8aca43d1fe5 && git checkout -B drift-repro 2e955dde6c058e629a439714695667184f5cb783 && git merge --no-ff 8037b1c346eb35e4e6b367e1b9b8a8aca43d1fe5

node scripts/docs-audit/affected-docs.mjs --json 2e955dde6c058e629a439714695667184f5cb783

⚠️ That checkout carried uncommitted changes, so the commit above does not fully identify what was read.

Advisory only, and a precision-first one (#9192): a page is listed because it names a
symbol, wire route or SDK method this diff touched — not because it mentions a changed
package. Each row says which anchor put it there, so a wrong row is reportable rather than
merely annoying. To re-verify, run the docs-accuracy-audit workflow scoped to these files:
node scripts/docs-audit/affected-docs.mjs 2e955dde6c058e629a439714695667184f5cb783 → pass the list as
args.docs, on the commit named under Which tree this was computed on.

This was referenced Oct 30, 2026
Closed
Closed
@objectstack-fleet

objectstack-fleet Bot commented Oct 30, 2026

Copy link
Copy Markdown
Contributor Author

domain:server#4 · os-elon-musk · session_016WV4d1Np3hU7RQnA13YZcL

维护者速读

席位意见：ACCEPT。

席位核对

Head-sha: 8037b1c346eb35e4e6b367e1b9b8a8aca43d1fe5

  • Shape: the Setup sidebar entries name each settings page as the hub does and list the same set (SMS Delivery and Data Lifecycle added); a parity pin in service-settings holds the two together (platform-objects cannot import the manifests without a cycle); sys_audit_log.action options carry labels (stored values unchanged; system.datasets.ts needed no change, since dimension labels come from the field's options); sys_notification shows the source object's label and Info / Warning / Critical. 17 files, +319 / −44. check-governed-merges --pr 28062: NOT governed.
  • PR body correction: its verification line cites f3487c44; the head adds one commit, the Setup tree count in packages/cli/test/connect-agent-both-halves-wire.pin.test.ts (32 → 34 for the two new entries, surface amended), which CI ran green.
  • Premise measured: on main the sidebar said Email for Mail Delivery and had no SMS Delivery / Data Lifecycle entries; the audit and notification pages showed raw keys. Three package suites and typechecks green; dispatch-gates 61 derived, 60 exit 0, 1 measured by CI (os-dev report 6521408387).
  • Gate check-runs on the head: 48 runs, 35 success, 13 skipped, 0 failure/pending; mergeable_state clean.
  • Contract review: not owed (check-owed-reviews lists nothing for this PR).
  • Accepted deviations: the surface took the parity test in service-settings, the plugin-audit action labels and bundle, and the cli count pin by claim amendment; Setup: System Overview and Notifications show raw values (config_change, approval.requested, lowercase severity) (#27521 row 4) #27855's open-vocabulary topic is not in this PR (a select would refuse unknown topics), so the PR says Refs #27855 and that card stays open for topic and the env_native label.
  • Out of scope, filed: i18n: the Data Lifecycle settings page reads English in every locale (no settings.lifecycle.* translations) #28064 (the Data Lifecycle hub page is untranslated in every locale; this PR pins it as HUB_UNTRANSLATED = ['lifecycle']).
  • Landing: under the maintainer's landing grant for this seat term (seat 4 thread, 2026-10-29 22:04Z): pr_ready + automerge_enable through the relay.

@objectstack-fleet objectstack-fleet Bot mentioned this pull request Oct 30, 2026
Closed
3 tasks
@objectstack-fleet
objectstack-fleet Bot marked this pull request as ready for review October 30, 2026 12:01
@objectstack-fleet
objectstack-fleet Bot enabled auto-merge October 30, 2026 12:01
@objectstack-fleet
objectstack-fleet Bot added this pull request to the merge queue Oct 30, 2026
Merged via the queue into main with commit 8cb8c7f Oct 30, 2026
49 checks passed
@objectstack-fleet
objectstack-fleet Bot deleted the claude/project-thread-9z96wv branch October 30, 2026 12:31
@github-actions github-actions Bot mentioned this pull request Oct 30, 2026
Closed
@objectstack-fleet objectstack-fleet Bot mentioned this pull request Nov 1, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@os-elon-musk os-elon-musk

Labels

documentation Improvements or additions to documentation size/m tests tooling Fix lands in tooling, not a product package — enters pm:queue only with Unblocks: or a named surface

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Setup: Settings sidebar and hub disagree — "Email" vs "Mail Delivery", SMS and Data Lifecycle missing from the sidebar (#27521 row 3)

2 participants

@os-elon-musk @claude