feat(spec): a form view's thank-you panel is translated through _views.VIEW.submitBehavior - #28195

📓 Docs Drift Check

This PR changes 3 package(s): @objectstack/cli, @objectstack/lint, @objectstack/spec, touching 12 documentable anchor(s).

3 hand-written doc(s) NAME something this change touched and may need an implementation-accuracy re-verification:

• content/docs/protocol/objectui/actions.mdx (via submitBehavior (literal, a string literal in FORM_ONLY_VIEW_TAILS; a string literal in ObjectTranslationDataSchema; a string literal in pushFormViewCopy; a string literal in validateTranslationReferences))
• content/docs/ui/forms.mdx (via submitBehavior (literal, a string literal in FORM_ONLY_VIEW_TAILS; a string literal in ObjectTranslationDataSchema; a string literal in pushFormViewCopy; a string literal in validateTranslationReferences))
• content/docs/ui/public-data-collection.mdx (via submitBehavior (literal, a string literal in FORM_ONLY_VIEW_TAILS; a string literal in ObjectTranslationDataSchema; a string literal in pushFormViewCopy; a string literal in validateTranslationReferences))

⛔ 3 release-owned page(s) also name something this change touched. These are read-only:

• content/docs/releases/v17/17-1.mdx (via submitBehavior (literal, a string literal in FORM_ONLY_VIEW_TAILS; a string literal in ObjectTranslationDataSchema; a string literal in pushFormViewCopy; a string literal in validateTranslationReferences))
• content/docs/releases/v17/17-7.mdx (via submitBehavior (literal, a string literal in FORM_ONLY_VIEW_TAILS; a string literal in ObjectTranslationDataSchema; a string literal in pushFormViewCopy; a string literal in validateTranslationReferences))
• content/docs/releases/v17/index.mdx (via submitBehavior (literal, a string literal in FORM_ONLY_VIEW_TAILS; a string literal in ObjectTranslationDataSchema; a string literal in pushFormViewCopy; a string literal in validateTranslationReferences))

content/docs/releases/ is RELEASE-OWNED (AGENTS.md "Documentation Guardrails"): release
notes are written centrally at release time, and a code PR that edits them is the exact PR
that guardrail exists to stop. They are still audited — read-only. If one of them is actually
wrong, file an issue or open a dedicated docs-only PR; do not edit it here.

# while this PR is open — GitHub drops the merge commit once it closes
git fetch origin e94bc15068987eccf1d83b871e7771af39a25922 && git checkout e94bc15068987eccf1d83b871e7771af39a25922
# afterwards, rebuild it from the two parents, which stay fetchable
git fetch origin c48cd2c103a9dfa99313a67a3ec622291d793900 af93f3475c2bf616499ece18571b07eb73022140 && git checkout -B drift-repro c48cd2c103a9dfa99313a67a3ec622291d793900 && git merge --no-ff af93f3475c2bf616499ece18571b07eb73022140

node scripts/docs-audit/affected-docs.mjs --json c48cd2c103a9dfa99313a67a3ec622291d793900

Advisory only, and a precision-first one (#9192): a page is listed because it names a
symbol, wire route or SDK method this diff touched — not because it mentions a changed
package. Each row says which anchor put it there, so a wrong row is reportable rather than
merely annoying. To re-verify, run the docs-accuracy-audit workflow scoped to these files:
node scripts/docs-audit/affected-docs.mjs c48cd2c103a9dfa99313a67a3ec622291d793900 → pass the list as
args.docs, on the commit named under Which tree this was computed on.

domain:spec#2 · os-tesla · session_01L9qibw58ehQ2gRHP2h2Puz

Contract-review-claim: session_01L9qibw58ehQ2gRHP2h2Puz · head af93f3475c2bf616499ece18571b07eb73022140 · 2026-10-30T16:45Z

At CONTRACT_REVIEW_TIER, by the maintainer's dedicated contract-review thread for the lanes (「开一个新的 fable thread，30分钟定时，负责车道的契约复审」, 2026-10-30T15:39Z), on the lane seat's behalf; the reviewer is not the drafter (session_01L9qibxqJVde7kDCjJSHEUo).

domain:spec#2 · os-tesla · session_01L9qibw58ehQ2gRHP2h2Puz

Contract review

Served-tier: CONTRACT_REVIEW_TIER
Head-sha: af93f3475c2bf616499ece18571b07eb73022140
Local-runs: none
Scope: packages/spec/src/system/i18n-resolver.ts, packages/spec/src/system/translation.zod.ts + packages/lint/src/validate-translation-references.ts and packages/cli/src/utils/i18n-extract.ts (the two _views readers the key is enforced and scaffolded by, read as one change with it), and the cited code read on the head: packages/spec/src/system/i18n-resolver.ts (translateFormTitle L1255-1286, valueOverridesPackagedBase L3970-3987, translateView L1455-1525), packages/spec/src/ui/view.zod.ts (FormViewSchema.submitBehavior discriminated union L4771-4850, the thank-you member's aliases L4794), packages/rest/src/form-routes.ts L350-358 (GET /api/v1/forms/SLUG runs translateMetadataDocument('view', …) and serves view.config as form), ui/apps/console/src/components/FormPage.tsx L2576-2578 and L2955-2959 (reads loaded.form.submitBehavior, draws title / message for thank-you), packages/spec/src/system/translation.zod.ts (ObjectTranslationDataSchema._views entry L297-390, the existing title and emptyState nests).

Inputs: card #28004 body and its three comments (claim 6526132447, file-surface amendment 6526224326, os-dev-report 6527607403); PR #28195 body, 12-file list and the diff against main (+598/-39); the check-runs on af93f347 (read 2026-10-30T16:54Z): 50 names, all completed, 39 success, 11 skipped, 0 failure; among the successes Governed Surface Queue Guard, Check Changeset, PR-body guards, Spec property liveness, Lint & Repo Gates (which runs the one locally NOT-MEASURED gate, check:dual-build-cjs-loads), Lint · PM dispatch-gates, Lint · docs & code guards, Lint · repo & tooling gates, the three scoped lints, Type Check · workspace/source/consumer/debt ledger, Test Core 1/8-8/8, Test UI, Live E2E UI, Build Core, Build Docs, Build UI Deps, Dogfood Regression Gate. Author user.login is objectstack-fleet[bot], so no login note is owed. The reviewer is not the drafter (session_01L9qibxqJVde7kDCjJSHEUo).

① Derived judgments

1. translation.zod.ts: the strict _views.<view> entry of ObjectTranslationDataSchema gains one optional nested key submitBehavior: { title?, message? }, itself a strictObject whose aliases (heading→title, text/body/description→message) mirror the thank-you member's own (view.zod.ts L4794, verified identical), with guidance prescriptions for url and kind (not display copy) and a thankYou→submitBehavior rename on the view node. The accept set of a translation bundle widens by exactly these two strings under every _views entry; everything else under the entry stays refused as before. Right, and the nesting is the file's own convention for a second heading on one node (emptyState.title), so the panel heading never aliases the form's title. Pinned by the schema-face cases in i18n-resolver.form-thank-you.test.ts (url refused unrecognized_keys at the panel path, kind refused with the prescription) and the regenerated translation.mdx; gen:strictness-ledger counts one more strict object (docs/audits/…/system.md).
2. i18n-resolver.ts: translateView now also overlays config.submitBehavior through translateFormSubmitBehavior, on the same _views node and viewTranslationKey the form title uses, with the same four rules as translateFormTitle (L1255-1286, read): only kind: 'thank-you'; only an authored non-empty string; ADR-0029 D9.2a override per string through the one valueOverridesPackagedBase, where a packaged view with no submitBehavior (packaged = {}) makes every served string an override and so keeps it, exactly as a packaged view with no title does for the title; a missing key keeps the authored string. Identity is preserved when nothing applies, so the config copy is made only on a change. Right. Pinned by the 11 new resolver cases (named and default form, locale chain, missing key, no invented message, redirect untouched with the same reference, keys do not cross, override vs catalog, no mutation).
3. The public door really carries it: form-routes.ts L350-358 runs translateMetadataDocument('view', match.view, bundle, { …, packagedBase }) inside GET /api/v1/forms/SLUG and serves view.config as the response form; FormPage.tsx L2576-2578 reads loaded.form.submitBehavior and L2955-2959 draws title / message for the thank-you kind. So the translated panel reaches an anonymous visitor with no ui/** change. Right, as the card asserted.
4. Lint validate-translation-references.ts: FORM_ONLY_VIEW_TAILS = {title, submitBehavior}; a submitBehavior key over a list view is an orphan with its own message, and the default form's key is legal for those two tails only (was title alone). Right, the same shape the title tail already had; pinned by the three new lint cases.
5. Extractor i18n-extract.ts: pushFormViewCopy emits _views.<key>.title and .submitBehavior.title / .message for container forms and viewKind: 'form' items under the same runtime key; a non-thank-you kind records both unauthored (pushOptional), as an untitled form records title. Right; the showcase's two authored panels gain their four zh-CN strings so check:i18n-coverage stays at none new (in the seat's amendment).

② Semver level

.changeset/28004-form-thank-you-translation.md: @objectstack/spec minor (new optional translation key + overlay), @objectstack/cli minor (os i18n extract scaffolds two new keys; coverage counts them), @objectstack/lint minor (a new accepted key and a new orphan message). Nothing is removed or tightened: a bundle without the key, and a form of another kind, behave byte-identically. Clause-②: yes and Metadata-protocol: added sit line-initial on the PR body and the changeset. Consistent.

③ Boundary flags

• open_questions: none declared.
• Files outside the order's first list (i18n-extract.ts, validate-translation-references.ts, the showcase translations): all three are in the seat's amendment 6526224326; answered in ①.4-5.
• Skills-docs: follow-up owed (skills/objectstack-i18n/SKILL.md _views.{view_name} row): the seat's follow-up; kept off this PR to stay off governed paths. Accepted.
• ui half: on the read in ①.3 the console already draws the served panel, so the reserved domain:ui card is verification-only; the seat decides. Agreed with the reading.
• ObjectFormPropsSchema.submitBehavior on a page component is the same thank-you block and is not translated by this PR (noted, not filed): see S1.
• Author: objectstack-fleet[bot]; no login note.

④ Design judgment

packages/spec/src/system/translation.zod.ts and packages/spec/src/system/i18n-resolver.ts against the card (#28004: declare the thank-you title / message on the _views entry and overlay them in translateView, with the lint/coverage that reads _views; no ui change) and their first consumer:

• The key holds against its consumer. The served form item's config.submitBehavior is the thank-you member { kind, title?, message? } (view.zod.ts L4790-4799); the resolver overlays the two optional strings and leaves kind alone; FormPage draws exactly those two. Nested under submitBehavior the address mirrors the authored path, so an author who knows the form shape knows the key, and the alias table means the everyday spellings (thankYou, heading, text) are renamed rather than refused. Right.
• Same rules as the form title, by construction. translateFormSubmitBehavior reuses valueOverridesPackagedBase, localeChain, pickData and viewTranslationKey; there is no second copy of the override comparison (the resolver's own ⛔ on that). The {} edge (packaged view without a panel) is the same conservative edge the title takes. Right.
• No invented copy. A panel that authors no message gains none, so the console's default wording stays in charge; a translation cannot add a string the form did not author. This is the correct boundary between catalog and authoring. Right.
• Flat keys not taken. thankYouTitle / thankYouMessage on the view node would sit beside the form title, the two-strings-one-node confusion the title key was built to avoid. Right.
• Strictness holds. The entry and the nested panel stay strictObject; url / kind carry prescriptions instead of silent acceptance.
• Nothing is retroactive. Existing bundles carry no submitBehavior; existing forms are served byte-identically.

Should-fix (none blocks the contract):

• S1 ObjectFormPropsSchema.submitBehavior (component.zod.ts, the page object-form block; the showcase new-project-wizard uses one) is the same thank-you block with no translation key either. The seat should file it as its own card (page component i18n), citing this record, so the gap does not stay "noted, not filed".
• S2 The _views docblock list in translation.zod.ts (L297-305) and the extractor's header comment were updated; skills/objectstack-i18n/SKILL.md is the one remaining place that lists the tails without the panel, which the owed follow-up covers. Land it with, not after, the next i18n skill edit.

Implemented-by: claude/project-thread-dlxqz6
Reviewed-by: session_01L9qibw58ehQ2gRHP2h2Puz

VERDICT: PASS

domain:spec#2 · os-tesla · session_01L9qibx5r5nhDMwpRs4SL6D

维护者速读

• 改了什么： 表单视图提交后的感谢页（submitBehavior 为 thank-you 时的 title / message）有了翻译键 objects.OBJECT._views.VIEW.submitBehavior.title / .message，translateView 把它套到下发的表单上；os i18n extract 会生成这两个键，lint 也认识它们。
• 为什么改： 公开表单换语言打开时标题和字段都翻了，提交后的感谢页却还是原文，没有键可翻。
• 风险与回滚： 只加可选翻译键，已有翻译包和其他三种提交行为不变；租户改过的文案照旧优先；作者没写的文案不会被翻译凭空加出来。回滚即 revert。
• 先看： packages/spec/src/system/i18n-resolver.ts（translateFormSubmitBehavior）、packages/spec/src/system/translation.zod.ts（_views.submitBehavior）。
• 两分钟验证： pnpm --filter @objectstack/spec exec vitest run src/system/i18n-resolver.form-thank-you.test.ts，预期 11 条全绿。
• 需要你做的： 无。不属于受管面，契约复审已 PASS，由席位落地。控制台已经直接画服务端下发的感谢页，不需要 ui 跟进卡。
• 席位意见： ACCEPT，可落地。

席位核对 · ACCEPT · domain:spec seat 2 (#18549) · 2026-10-30T17:01Z

Head af93f3475c2bf616499ece18571b07eb73022140. Card #28004, claim 6526132447 + file-surface amendment 6526224326.

• Shape: draft to main, made by the relay; Fixes #28004 alone; Clause-②: yes, Metadata-protocol: added at line start. Skills-docs: rewritten from follow-up owed to follow-up #28215 in this act. Changeset @objectstack/spec, @objectstack/cli, @objectstack/lint all minor.
• Contract review: PASS at CONTRACT_REVIEW_TIER by the lane review thread, record 6528389425 on this head, reviewer not the drafter. No must-fix. S1 (the page object-form block's thank-you panel has no key either) is filed as A page's object-form thank-you panel has no translation key #28214; S2 (the skill's _views row) is skills: list the form thank-you translation keys in the objectstack-i18n _views row #28215, to land with the next i18n skill edit.
• Diff read by the seat: the overlay reuses the form title's override comparison, locale chain and key builder, with no second copy; the nested address mirrors the authored path; only authored copy is translated. The three files beyond the order's first list are inside the amendment.
• ui half decided: none filed. The record's ①.3 traces GET /api/v1/forms/SLUG translating the view before serving it and FormPage.tsx drawing the served title / message, so the translated panel reaches the visitor with no ui/** change; the reserved ui card would be verification only.
• Follow-ups filed: A page's object-form thank-you panel has no translation key #28214 (page object-form thank-you translation, spec), skills: list the form thank-you translation keys in the objectstack-i18n _views row #28215 (skills/objectstack-i18n/SKILL.md, Tier H).
• Gates: check-runs on this head 43 success, 15 skipped, 0 red. mergeable_state clean. check-governed-merges --branch: NOT governed, 12 paths, +598/−39.
• Authority: maintainer standing go-ahead 「按 pm-dispatch 审过的pr你可以自主落地」 (2026-10-30T14:20Z, project thread).
• Landing: pr_ready + automerge_enable in this act.