Skip to content

feat(setup): retire Packaged automation's flows half; Packaged actions is its own Setup entry - #28785

Merged
objectstack-fleet[bot] merged 1 commit into
mainfrom
claude/project-thread-g4z84u
Nov 1, 2026
Merged

objectstack-fleet[bot] merged 1 commit into
mainfrom
claude/project-thread-g4z84u

Conversation

@objectstack-fleet

Copy link
Copy Markdown
Contributor

Requested by Steedos · project thread

Part of #28578

PR 1 of 2. Wanted 1, 2, 4 and 5 (Setup's metadata pages into Studio's All metadata area) follow in a second PR on this branch, after this one merges. That PR closes the card. The split keeps each PR under the 3000-line human-merge threshold (claim amendment 6561871570).

维护者速读

  • 改了什么:设置 › 打包自动化页面的"流程"一半下线(ADR-0146 D11)。导航项 nav_packaged_automation(automation:packaged)换成 nav_packaged_actions("Packaged Actions",automation:packaged-actions),页面只保留打包动作的开关列表。Studio 不再链接到这个下线的页面。
  • 为什么改:ADR-0146 D4 已把打包流程的开关和"新建类似"放进 Studio 的自动化栏。设置里的流程页已经重复,D11 判定下线。
  • 风险与回滚:风险低。旧页面的流程开关和克隆在 Studio 里都有对应入口。旧 URL /apps/setup/component/automation/packaged 不再对应任何页面。回滚就是 revert 本 PR。
  • 先看:packages/platform-objects/src/apps/setup-nav.contributions.ts、ui/packages/app-shell/src/views/setup/PackagedActionsPage.tsx、ui/packages/app-shell/src/services/builtinComponents.tsx。
  • 两分钟验证:打开设置,"应用"分组里应该看到"Packaged Actions",点开只有动作开关。打开 Studio › 组织流程(/studio/~org/automations),空状态不再链接到设置。
  • 需要你做的:无。

What changes

  • Setup navigation (@objectstack/platform-objects). nav_packaged_automation is replaced by { id: 'nav_packaged_actions', type: 'component', label: 'Packaged Actions', componentRef: 'automation:packaged-actions', icon: 'zap' }, in group_apps beside Packages. Like the old entry it has no requiresService and no requiredPermissions. The label is in en, zh-CN, ja-JP and es-ES, with the source-hash rows moved. nav_packaged_automation joins the dead-key tombstone.
  • The page (@object-ui/app-shell). The new PackagedActionsPage is a page header plus PackagedActionsSection (headed={false}). builtinComponents registers it as automation:packaged-actions and no longer registers automation:packaged. PackagedAutomationPage.tsx and its test are removed, and the index.ts export becomes PackagedActionsPage. The shared helpers packagedFlows.ts, packagedFlowLedger.ts and packagedActions.ts stay; Studio uses them.
  • Studio stops linking to the retired page. The Organization flows empty state reads "No flows outside a package. To change a packaged flow, open its package and use New similar." and has no action. The en and zh keys are reworded, and engine.studio.org.openSetup is removed from the Studio namespace. BuilderLanding drops packagedAutomationPath.
  • Platform checklist. The one citation in docs/qa/platform-checklist/areas/automation.json that named setup-nav.contributions.ts#nav_packaged_automation now names #nav_packaged_actions. Claim amendment 6561766478 added this to the surface, and check-platform-checklist --changed-from origin/main reported it as a LOST anchor until it was re-pointed.

Why

ADR-0146 D4 put a packaged flow's on/off switch and its copy (New similar) into Studio's Automations pillar. D11 retires the Setup page that duplicated them. Setup keeps the operational state for packaged actions, which has no Studio home.

Tests

  • setup-packaged-actions-nav.test.ts (renamed from setup-packaged-automation-nav.test.ts) pins the new entry: its ref, group, no gates, and that it parses. It also pins the retired id and ref staying absent.
  • setup-nav-dead-key-tombstone.test.ts gains nav_packaged_automation.
  • PackagedActionsPage.navContribution.test.tsx (renamed) checks that the ref resolves with @object-ui/app-shell as source and automation/packaged-actions as segments, that the page mounts through ComponentNavView with one "Packaged actions" heading, and that automation:packaged resolves to nothing.
  • New noRetiredSetupLink-28578.test.ts reads every Studio source with comments masked and refuses automation:packaged and automation/packaged. It also has a matcher control. Run against the 272fec05 copies of BuilderLanding.tsx, the pattern catches the base's automation:packaged.
  • StudioDesignSurface.homeLoop-12513, StudioDesignSurface.packageLessFlows-11553 and BuilderLanding.setupExit-12513 are updated to the new empty state and the missing route builder.

Verification

Base 272fec05.

  • @objectstack/platform-objects: vitest run src/apps gave 37 files and 578 tests green. typecheck is green.
  • ui: 146 test files under the verify lock (--maxWorkers=2), 1772 tests green after one stale string was fixed. The set is narrowed to every app-shell and console test that names the touched modules (PackagedActions, packagedFlows, builtinComponents, BuilderLanding, auto-empty, engine.studio.org., ~org, automation:packaged), plus all of packages/i18n. The full app-shell suite is left to CI's Test UI shards.
  • Type-check: @object-ui/app-shell, @object-ui/console and @object-ui/i18n are green.
  • node scripts/check-platform-checklist.mjs --changed-from origin/main: 0 lost.
  • node scripts/pm/dispatch-gates.mjs --commands: 68 commands. 65 exited 0, including check-sdui-manifest, check:platform-checklist, check:nul-bytes and pnpm --dir ui exec vitest run scripts/ (171 files). check:i18n exited 3 for a prerequisite, and after the prerequisite build it is green: all 10 packages' bundles are in sync. Two are left to CI because their prerequisites are not met here: check:dual-build-cjs-loads needs a whole-workspace build, and check-plugin-teardown-shape --self-test needs an unshallow clone.
  • PR-body gates on this body: check-changeset-no-major, check-adr-0087-registration, check-closing-keyword-parity and check-partof-closing-keyword are green.

Clause-②: no
Metadata-protocol: none

Human Minimum

  • 1. Schemas start as Zod; packages/spec holds no runtime logic. (packages/spec untouched.)
  • 2. Every name I added uses the casing for its kind.
  • 3. No formatter ran; pnpm lint passes.
  • 4. One issue, one branch off an up-to-date main, one pull request. (PR 1 of 2 for Setup: retire Setup → Metadata behind redirects into Studio (datasource kept) and retire Packaged automation's flows half; Studio stops linking into Setup #28578; the split is the seat's call, recorded on the card.)
  • 5. A change that publishes carries a changeset, and both declaration lines are filled in here and in the changeset.
  • 6. packages/spec touched: n/a.
  • 7. No hand edits to content/docs/references/, packages/*/CHANGELOG.md or content/docs/releases/.
  • 8. Title, body and comments are in English, except the 维护者速读 section, which the lane writes in Chinese for the maintainer.
  • The Before Submitting list in CONTRIBUTING.md is done.

🤖 Generated with Claude Code

https://claude.ai/code/session_01QsR2jRKMRpKnN9FkAvSWGr

…s is its own Setup entry

ADR-0146 D11: a packaged flow's switch and its copy are Studio's (D4), so
Setup's packaged FLOWS page retires. nav_packaged_automation
(automation:packaged) becomes nav_packaged_actions
(automation:packaged-actions), which opens the actions switch list alone.
The retired id is tombstoned, and the four locales carry the new label.

Studio stops linking to the retired page: the Organization flows empty
state says how to change a packaged flow and links nowhere, and
BuilderLanding drops packagedAutomationPath. A source pin refuses the
retired ref or URL in any Studio source. The platform checklist citation
is re-pointed at the new entry.

Co-Authored-By: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QsR2jRKMRpKnN9FkAvSWGr
@github-actions github-actions Bot added size/xl documentation Improvements or additions to documentation tests tooling labels Nov 1, 2026
@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

📓 Docs Drift Check

6 anchor(s) derived from 1 changed package(s); no hand-written page names any of them, so this run has nothing to list — not a clean bill of health. This check sees only pages that NAME a derived anchor: one that documents this change in prose, or enumerates it in an authoring dialect, names none and stays invisible to it on every run.

What this run could not see

Coarse fallback — 2 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): node scripts/docs-audit/affected-docs.mjs --json a00f3359112456e64586ab043ba77d41d0b32119 → packageMentionDocs.

Which tree this was computed on

This run read content/docs from 49b3b81e785c7be8812904d1acac10db4f364415 — the merge of head 93d0cab55c8de9d8772a37cdbab7d6aeb2060324 into base a00f3359112456e64586ab043ba77d41d0b32119, which is what actions/checkout gives a pull_request run. Not the PR head.

A worktree cut from an older main holds a different content/docs, so re-deriving there can legitimately return a different list — that is a different tree, not a wrong row. To answer on the same tree:

# while this PR is open — GitHub drops the merge commit once it closes
git fetch origin 49b3b81e785c7be8812904d1acac10db4f364415 && git checkout 49b3b81e785c7be8812904d1acac10db4f364415
# afterwards, rebuild it from the two parents, which stay fetchable
git fetch origin a00f3359112456e64586ab043ba77d41d0b32119 93d0cab55c8de9d8772a37cdbab7d6aeb2060324 && git checkout -B drift-repro a00f3359112456e64586ab043ba77d41d0b32119 && git merge --no-ff 93d0cab55c8de9d8772a37cdbab7d6aeb2060324

node scripts/docs-audit/affected-docs.mjs --json a00f3359112456e64586ab043ba77d41d0b32119

⚠️ That checkout carried uncommitted changes, so the commit above does not fully identify what was read.

@objectstack-fleet

Copy link
Copy Markdown
Contributor Author

domain:ui#1 · zhuangjianguo · session_01QsR2jUJ19MstFvFhjgiYTu

席位核对 · ACCEPT · 2026-11-01T20:04Z

Head-sha: 93d0cab55c8de9d8772a37cdbab7d6aeb2060324

  • Shape: draft → main, first content line Part of #28578 (PR 1 of 2, per amendment 6561871570; PR 2 closes the card). 28 files, +294 / −1944 (2238 lines ≤ 3000), no governed path (check-governed-merges --pr 28785: NOT governed). Clause-②: no / Metadata-protocol: none line-initial in body and changeset, as claimed (6561334639). @object-ui/app-shell is private, so the retired PackagedAutomationPage export narrows nothing published. Every file is inside the claim plus amendment 6561766478 (the one QA checklist citation).
  • Read in the diff (Wanted 3): nav_packaged_automation / automation:packaged retire; nav_packaged_actions / automation:packaged-actions mounts the new PackagedActionsPage over the kept PackagedActionsSection (D4 keeps the action switch in Setup). PackagedAutomationPage.tsx and its test are deleted; packagedFlows.ts, packagedFlowLedger.ts and packagedActions.ts survive for Studio. The nav pin is inverted (setup-packaged-actions-nav.test.ts), the tombstone gains the retired id, and five locales' nav labels and source hashes follow. Studio's packagedAutomationPath link and the ~org empty-state link are gone, pinned by noRetiredSetupLink-28578.test.ts.
  • Gates (check-runs on this head): 56 success, 8 skipped, 0 failed or pending. mergeable_state clean.
  • Tests (dev): platform-objects src/apps 37 files / 578 tests; ui narrowed set 146 files / 1772 tests; type-check app-shell, console, i18n, platform-objects green; 65 of 68 local gates exit 0, the other three exit on prerequisites and are green in CI.
  • Acceptance notes: routed the dev's findings. The stale QA entry (automation.json ~2262-2365) is noted on N-29 QA checklist: rewrite the Setup-designer items to the Studio door and add the .custom customization journey, with one live e2e through Studio #28579; the 20 dead packagedAutomation.* i18n keys and the connector-credentials-ui.ts:12 comment are filed as i18n: retire the packagedAutomation flows and clone keys left dead by the retired Packaged automation page #28789 (a narrowing, so not here).
  • Owed by PR 2, not a defect of this PR: a bookmark of the retired /apps/setup/component/automation/packaged now renders "Component not registered". The card's business reason says old Setup links must land in Studio, so PR 2's redirect table carries that URL too, until then the gap is one merge wide.
  • Out of scope / NOT MEASURED: no live Console run by the seat.
  • Landing: ordinary queue landing, pr_ready then automerge_enable. Part of closes nothing.

@objectstack-fleet
objectstack-fleet Bot marked this pull request as ready for review November 1, 2026 20:05
@objectstack-fleet
objectstack-fleet Bot enabled auto-merge November 1, 2026 20:05
@objectstack-fleet
objectstack-fleet Bot added this pull request to the merge queue Nov 1, 2026
Merged via the queue into main with commit 0aaad18 Nov 1, 2026
65 checks passed
@objectstack-fleet
objectstack-fleet Bot deleted the claude/project-thread-g4z84u branch November 1, 2026 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation size/xl tests tooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant