Repository navigation
docs(adr): record the #28971 personal-view ruling at ADR-0131 D13 and ADR-0017 - #29321
Conversation
…ADR-0017 Append one dated note under ADR-0131 D13 and one under ADR-0017's `personal` scope bullet: named personal views are a user-owned D3 object (ruled, no longer parked), they are not view items and do not reuse scope 'personal', and the first version follows the four personalization hygiene cards. No existing ADR text changes. Claude-Session: https://claude.ai/code/session_01ADHkmPtNBPh7cTMHdPYPrT Co-authored-by: Claude <noreply@anthropic.com>
|
domain:spec#1 · os-steve · session_01ADHkmPi25XXKx92Xmg4viS Head-sha: 维护者速读
席位意见:可落地,等契约复审,之后等你批准。 席位核对 — ACCEPT ·
|
…w notes ADR-0131 note: the first-version execution card is future, filed once the four hygiene cards have landed. ADR-0017 note: name ADR-0131 in the bold lead, and add the ruling's two design constraints (no view-item name syntax for a personal view's id; no unnamed preference layer on top) as a pointer for reading section 3.1 and the overlay text. Still append-only against main. Claude-Session: https://claude.ai/code/session_01ADHkmPtNBPh7cTMHdPYPrT Co-authored-by: Claude <noreply@anthropic.com>
|
domain:spec#1 · os-steve · session_01ADHkmPi25XXKx92Xmg4viS Contract-review-claim: session_01ADHkmPi25XXKx92Xmg4viS · head 29c1fd1 · 2026-11-02T12:31Z |
|
domain:spec#1 · os-steve · session_01ADHkmPi25XXKx92Xmg4viS Contract reviewServed-tier: Inputs read: the card and every comment on it, the ruling comment and its card, the PR body, its file list, the net diff against ① Derived judgments
② Semver level
③ Boundary flags
④ Design judgmentADR-0131 (D13 note). Says what the ruling says on the three points the card orders, and nothing contrary. Every factual claim checked against the live tree and the cited cards:
Findings:
ADR-0017 (§2
Findings:
House rules for amending an Accepted ADR. Must-fix: none. The three should-fixes are wording and completeness; none makes a note say something false or contrary to the ruling of record, and none blocks the maintainer's approval. Implemented-by: VERDICT: PASS |
|
domain:spec#1 · os-steve · session_01ADHkmPi25XXKx92Xmg4viS Contract-review-claim: session_01ADHkmPi25XXKx92Xmg4viS · head 968a13a · 2026-11-02T12:41Z |
|
domain:spec#1 · os-steve · session_01ADHkmPi25XXKx92Xmg4viS Contract reviewServed-tier: Delta review. This head is one commit ( ① Derived judgments
② Semver levelUnchanged: ③ Boundary flags
④ Design judgmentADR-0131 (D13 note). One sentence changed. "gets its own execution card once the four cards above have landed" now matches the ruling ("When all four blockers are closed, the seat … files the first-version execution card") and the card body ("The first version gets its own execution card once all four blockers are closed"). Every other claim re-holds from the previous record: ADR-0017 (§2 House rules for amending an Accepted ADR. Unchanged and followed: appended dated blockquote citing the ruling record, card, letter and the maintainer's untranslated word; no text moved or reversed; numbers and files untouched; the generated index needs no regeneration. Must-fix: none. Should-fix: none. The three should-fixes of the previous record are closed by this commit; no new finding. Implemented-by: VERDICT: PASS |
Requested by Steve · project thread
Fixes #29038
Clause-②: no
Metadata-protocol: none
维护者速读
personal层下各追加一条日期注(2026-11-02),记录 [Decision] Named personal list views: can a reader save their own named list, and what is the end state? #28971 的裁决 C。scope: 'personal'。docs/adr/0131-total-organization-ownership-no-null-organization-id.mdD13 后的注;docs/adr/0017-object-has-many-view.md第 2 节personal条下的注。git diff origin/main...HEAD --stat应只见两文件、+22/−0。What changes
Two append-only dated notes, each citing the ruling of record
6570568131on #28971 (letter C, maintainer 「同意」):docs/adr/0131-total-organization-ownership-no-null-organization-id.md: a blockquote note after the D13 paragraph, before D14.docs/adr/0017-object-has-many-view.md: an indented blockquote note under thepersonalbullet of section 2's "Three scopes" list.Each note says the three things the card asks for:
scope: 'personal'.Each note also points at #29037 as the card that retires the inert
personaldeclarations, and says the text it sits under stays as written and is read through the note. The ADR-0017 note also covers its Status line's "a per-user view scope is a parked v18 direction".No existing ADR text changes: the diff is +22 / −0. Neither Status line was edited (the card's acceptance says no other text changes); see Acceptance notes.
Why
ADR-0131 D13 called a per-user "personal view" scope "the parked v18 direction" and said that, if pulled, it "returns as a user-owned D3 object". The maintainer pulled it on #28971. Without a note, both records still read as parked.
Verification
Gates derived by
node scripts/pm/dispatch-gates.mjs --commands --repo objectstack-ai/objectstackon head29c1fd16: 21 commands, all run, all exit 0.--ranreconciliation: 21 derived, 21 run, 0 NOT-MEASURED, 0 UNRUN (a DERIVED zero).Gate readings (head 29c1fd1)
node scripts/check-adr-links.mjsand--self-test: exit 0node scripts/check-closing-keyword-parity.mjsand--self-test: exit 0node scripts/check-comment-mask-corpus.mjs: exit 0node scripts/ci/plan-test-core-shards.mjs --self-test: exit 0pnpm --filter @objectstack/lint run check:doc-formula-expressions: exit 0 (afterturbo run build --filter='@objectstack/lint...'under os-verify-lock, VERDICT command-exit 0)pnpm check:adr-anchors,check:adr-index,check:adr-symbol-anchors: exit 0.adr-index --report: "docs/adr/README.md is current", so no index regeneration.pnpm check:ci-filter-parity,check:closed-ceremony-text,check:cross-package-test-inputs,check:doc-authoring,check:driver-memory-census,check:gitlink-declared,check:nul-bytes,check:pm-governed-merges,check:pm-prior-rulings,check:refd-timer-probe,check:watch-hint-literal: exit 0Governed tier:
node scripts/pm/check-governed-merges.mjs --teston both paths answersgoverned: true,tier: "H"(surfacedocs/adr/**). This PR stays a draft and waits for a GOVERNED_APPROVERS approval.No changeset:
docs/adr/**publishes nothing, so the PR carriesskip-changeset. No tests or packages are touched, so there are no forced test edits and no ablation.Acceptance notes
**Status**:line gained anAmendedentry. Both files use that line for amendments, but the card's acceptance says no other text in either ADR changes. If the reviewer wants a Status-line pointer, it is a one-line follow-up.Generated by Claude Code