fix(app-shell): inside a package's second app, the sidebar and nav:menu links stay in that app by objectstack-fleet[bot] · Pull Request #29430 · objectstack-ai/objectstack

objectstack-fleet · 2026-11-02T14:47:16Z

Requested by Steedos · project thread

Fixes #29328

Clause-②: no
Metadata-protocol: none

The two lines are copied from the claim (comment 6577088246).

维护者速读

改了什么：侧边栏的导航链接、侧边栏按路由选区（area）时读的路径前缀，以及 nav:menu 页面块的链接前缀，改为用应用自己的地址 appAddressSegment（在完整应用元数据列表中求值）：包 ID 能回到这个应用时用包 ID，否则用应用名。
为什么改：/apps/包ID 总是打开该包的第一个应用。一个包里有两个应用（例如 crm 与 crm_service）时，在第二个应用里点侧边栏任何一项，都会跳进第一个应用，换成别的应用的导航、顶栏和首页。console avatar menu: a hidden app that shares its package with the package's first app opens the first app instead of itself #29024 已经修了头像菜单、⌘K、应用切换器、首页磁贴和报表索引，侧边栏还是旧算法。
风险与回滚：只改链接前缀的计算；包内第一个或唯一应用的链接逐字节不变（测试钉住了这两种对照）。appAddressSegment 是 AppContent 已在用的现有函数，不新增导出。回滚即撤销本 PR。
先看：layout/UnifiedSidebar.tsx 的两处 basePath（areaRoute 与导航）；views/nav-menu-renderer.tsx 的 basePath；新测试 UnifiedSidebar.packageAppAddress-29328.test.tsx。
两分钟验证：pnpm --dir ui exec vitest run packages/app-shell/src/layout/__tests__/UnifiedSidebar.packageAppAddress-29328.test.tsx packages/app-shell/src/views/__tests__/nav-menu.packageAppAddress-29328.render.test.tsx，预期 7 个用例通过（在 main 上其中 3 个第二应用用例为红）。
需要你做的：无，席位落地。

What changes

Sidebar (layout/UnifiedSidebar.tsx): the nav basePath every entry link is built on, and the basePath of the route the area election reads, are /apps/ plus appAddressSegment(apps, activeApp) over the full metadata app list (the list AppContent resolves /apps/SEGMENT on), instead of appRouteSegment(activeApp), the package id. Inside a package's second app the area holding the routed entry is now elected too: with the package-id prefix no entry of the second app matched the route.
nav:menu block (views/nav-menu-renderer.tsx): its basePath is built the same way.
Both import appAddressSegment from utils/appRoute.js, as AppContent and CommandPalette do; the utils barrel does not re-export it, and the sidebar tests that mock the barrel keep working unchanged.
A package's first or only app keeps its package-id links byte for byte.

Tests

layout/__tests__/UnifiedSidebar.packageAppAddress-29328.test.tsx, through the real UnifiedSidebar, NavigationRenderer and route helpers (the utils module is not mocked): com.example.crm ships crm (first) and crm_service (two areas); com.example.hr ships hr alone. Inside crm_service an entry links to /apps/crm_service/crm_queue; at /apps/crm_service/crm_case the Casework area is elected and its object and dashboard entries link into crm_service. Controls: crm keeps /apps/com.example.crm/..., hr keeps /apps/com.example.hr/....
views/__tests__/nav-menu.packageAppAddress-29328.render.test.tsx, through the real nav:menu block under SchemaRenderer and MePermissionsProvider: inside crm_service its object and dashboard links carry /apps/crm_service/...; the same two controls.
Red on main: both files run against origin/main 2f7977cd before the fix: 3 failed (the three second-app cases; received /apps/com.example.crm/crm_queue, /apps/com.example.crm/crm_case and the first area elected), 4 passed (the controls).

Acceptance notes

Real browser: NOT MEASURED. No two-app package was staged on a running Console; the jsdom tests above go through the real sidebar and block.
Noted by the card, not measured here and not changed: other appRouteSegment(app) link builders (AppSwitcher's setup path, the marketplace deploy button, ConsoleShell's setup alias).

Verification

Head ada58c18. The fix is commits 23551407 and c1354524 (based on origin/main 2f7977cd); ada58c18 merges origin/main after PR #29327 and PR #29325 landed (none of this PR's files changed; clean). The branch's delta against main is the five files above. Readings name their head; the final head's are CI's check-runs.

Tests

ada58c18, after rebuilding the app-shell dependency closure: every ui test file naming UnifiedSidebar, nav-menu-renderer or NavMenuRenderer (70 files, the two new ones included): 70 passed, 553 tests passed, at --maxWorkers=2 under the verification lock. The same set on the fix head before the merge: 69 files, 546 tests passed.
turbo run type-check --filter=@object-ui/app-shell (tsc --noEmit and the test tsconfig): 65 of 65 tasks successful on the fix head and again on ada58c18.

Gates

ada58c18: node scripts/pm/dispatch-gates.mjs --commands derived 34 families for this diff (the same list as on the fix head); all 34 ran with exit 0, pnpm --dir ui exec vitest run scripts/ among them (169 files passed, 2 skipped; 4921 tests passed). --ran reconciled 34 derived, 34 run, 0 NOT-MEASURED. The changeset, ADR-0087, closing-keyword and Part-of gates ran against this body.
node scripts/check-sdui-manifest.mjs: exit 0 (no registry change).
pnpm check:new-line-citations (under ui/): 0 new citations.
The CI-only type-check lanes and the whole-tree families are CI's; their check-runs on this PR are the reading.

Generated by Claude Code

… app by name Build the sidebar's nav basePath, the area-election route basePath and the nav:menu block's basePath on appAddressSegment over the full metadata app list instead of appRouteSegment (the package id), which opens the package's first app. A package's first or only app keeps its package-id address. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QsR2jUtBT7bo7SPANQh2LX

The utils barrel does not re-export it; AppContent and CommandPalette import it from utils/appRoute.js the same way. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QsR2jUtBT7bo7SPANQh2LX

…-he5cdc

objectstack-fleet · 2026-11-02T15:03:02Z

domain:ui#1 · zhuangjianguo · session_01QsR2jUJ19MstFvFhjgiYTu

席位核对 · ACCEPT · 2026-11-02T15:02Z

Head-sha: ada58c18b33a87ef70b8cd59dd5529ff233f4fd3

Shape:
- The PR is a draft against main. The first card line is Fixes #29328, under claim 6577088246.
- 5 files, +345 / −5: UnifiedSidebar.tsx (the import and the two basePath lines), nav-menu-renderer.tsx (the import and its basePath line), two new tests and a root changeset. That is the claimed surface, and it stays off Console: unlabeled sidebar object entries and Home recents still read whole metadata lists #29235's line. check-governed-merges --pr 29430: not governed, 350 changed lines, under the human-merge threshold.
- Clause-②: no and Metadata-protocol: none start their lines in the body and the changeset, as claimed. No export, prop or pack key is new. The changeset is patch.
Read in the diff:
- The sidebar's area-route basePath, its nav basePath and nav:menu's basePath now build on appAddressSegment(apps, activeApp). This is the helper AppContent and PR fix(app-shell): a package's non-first app opens itself from the avatar menu, palette, switcher, Home tiles and report index #29327 already use.
- apps is the full metadata list in both files, so a package's first or only app keeps the package id byte for byte, and a later app is addressed by its name.
- It is imported from utils/appRoute.js directly: the barrel doesn't re-export the helper, and 23 sidebar tests mock the barrel.
- The area memo still keys on activeApp?.name, not apps. A package gaining a second app while the sidebar is mounted would keep the old segment until the next route change. That is a narrow edge, and the seat does not hold the PR for it.
Pins changed: none.
Gates (check-runs on this head): 44 success, 11 skipped, 0 failed or pending. mergeable_state is clean.
Tests (dev):
- On main 2f7977cd the new files fail 3 (the second-app cases) and pass 4 (controls: the first app and a single-app package).
- At ada58c18: 70 sidebar and nav files, 553 tests. app-shell type-check is 65 of 65. Derived gates 34 of 34, 0 NOT-MEASURED.
- Main was merged after fix(app-shell): a package's non-first app opens itself from the avatar menu, palette, switcher, Home tiles and report index #29327 and perf(layout): the phone nav drawer opens in one render, and its opening frame draws only the rows that fit #29325 landed, clean.
NOT MEASURED: the seat ran no live session, and the dev measured in jsdom only, not in a real browser.
Findings: not filed. The dev names other appRouteSegment link builders (AppSwitcher's setup path, the marketplace deploy button, ConsoleShell's setup alias), unmeasured. console sidebar: inside a package's second app, the sidebar links open the package's first app #29328 already lists them under "noted, not measured".
Serial: none open.
Landing: ordinary queue landing, pr_ready then automerge_enable. Fixes #29328 closes the card on merge.

claude added 3 commits November 2, 2026 12:32

Merge remote-tracking branch 'origin/main' into claude/project-thread…

ada58c1

…-he5cdc

github-actions Bot added size/m documentation Improvements or additions to documentation tooling Fix lands in tooling, not a product package — enters pm:queue only with Unblocks: or a named surface labels Nov 2, 2026

objectstack-fleet Bot marked this pull request as ready for review November 2, 2026 15:03

objectstack-fleet Bot enabled auto-merge November 2, 2026 15:03

objectstack-fleet Bot added this pull request to the merge queue Nov 2, 2026

Merged via the queue into main with commit 6fe99f8 Nov 2, 2026
56 checks passed

objectstack-fleet Bot deleted the claude/project-thread-he5cdc branch November 2, 2026 15:23

objectstack-fleet Bot mentioned this pull request Nov 2, 2026

console sidebar: inside a package's second app, the sidebar links open the package's first app #29328

Closed

github-actions Bot mentioned this pull request Nov 2, 2026

4-hourly full run: red on main (CI) #29494

Closed

Navigation Menu

Repository navigation

fix(app-shell): inside a package's second app, the sidebar and nav:menu links stay in that app - #29430

fix(app-shell): inside a package's second app, the sidebar and nav:menu links stay in that app#29430
objectstack-fleet[bot] merged 3 commits into
mainfrom
claude/project-thread-he5cdc

objectstack-fleet Bot commented Nov 2, 2026

Uh oh!

objectstack-fleet Bot commented Nov 2, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

objectstack-fleet Bot commented Nov 2, 2026

维护者速读

What changes

Tests

Acceptance notes

Verification

Uh oh!

objectstack-fleet Bot commented Nov 2, 2026

席位核对 · ACCEPT · 2026-11-02T15:02Z

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant