fix(app-shell): optional choice rows in Studio metadata forms can be cleared again - #29805

Requested by Steedos · project thread

Fixes #29733

Clause-②: no
Metadata-protocol: none

Claim: 6595203212 (amendment 6595600429)

维护者速读

• 改了什么:Studio 元数据表单里「可选」的下拉选项(枚举字段)现在第一项是「— 无 —」,选它即把该键从元数据里删掉(恢复为「未声明」)。必填的下拉、以及列表里的单个元素不变,不出现这一项。另外修了同一条链路上的第二个原因:动作、仪表盘、钩子、页面、报表五个编辑器的「更多字段」区,清空任何一项(选「无」或清空文本框)以前会被宿主的合并立刻还原,现在清空能落到草稿并保存为「无此键」。
• 为什么改:卡片 Studio metadata forms: an optional enum select has no empty item, so a chosen deleteBehavior on a user field cannot be cleared #29733 指出可选枚举选过一次就回不去「未声明」;对 user 字段的 deleteBehavior 来说「未声明」本身就是一种生效的语义(不进删除级联)。实测发现 Studio 的字段面板目前根本不显示 deleteBehavior 这一行(席位另立卡),但缺陷本身在「更多字段」区可复现(动作的 openIn 只能在 self / new-tab 之间选)。
• 风险与回滚:只改界面,不动任何元数据契约;必填项、无值时的占位文字、合并逻辑本身都不变。清空的键以 undefined 进入草稿,保存时 JSON 自然省略。回滚即 revert 本 PR。
• 先看:ui/packages/app-shell/src/views/metadata-admin/SchemaForm.tsx 的 offerUnset 与两处 Select;inspectors/fallbackFormPatch.ts;五个 DefaultInspector 各一行 onChange。
• 两分钟验证:pnpm --dir ui exec vitest run packages/app-shell/src/views/metadata-admin/SchemaForm.optionalEnumUnset-29733.test.tsx packages/app-shell/src/views/metadata-admin/inspectors/fallbackFormPatch-29733.test.tsx,预期 12 个用例全部通过。
• 需要你做的:无,席位落地。

What changes

1. An optional enum select offers "— None —". Both builtin select paths of the metadata-admin SchemaForm (a form row's options, and a schema property's own enum) listed only the enum values, so an optional key, once picked, could never return to absent. FieldControl now leads an optional row's list with a "— None —" item: the existing engine.form.none key (en "— None —", zh "— 无 —"), the word the metadata-admin pickers already use, so no new i18n key. Radix refuses an item whose value is the empty string, so the item carries a sentinel that onValueChange maps back to undefined, the form's existing clear convention (setField deletes the key; a repeater row keeps an undefined that serialisation drops). With nothing set, the trigger still shows the "Select…" placeholder and nothing is written on render.

2. Clears in the "More fields" fallback form reach the draft. The action, dashboard, hook, page and report default inspectors render a fallback SchemaForm and wired it onChange={(next) => onPatch(next)}. The host's onPatch merges the patch over the draft, and SchemaForm reports a clear by deleting the key from next, so the merge kept the old value: a None pick, an emptied text box or an emptied number box there was undone at once. The new pure helper fallbackFormPatch(draft, next) returns next plus every key the draft had and next dropped, set to undefined; the five call sites route through it. onPatch's merge itself is unchanged, and a key the form did not touch is never turned into undefined.

Tests

• SchemaForm.optionalEnumUnset-29733.test.tsx (new, 8), over the real SchemaForm: the schema-enum path and the form-options path each emit an object without the key after "— None —" (nothing else moves); a repeater card row (the object form's fields rows, where deleteBehavior sits) serialises without the key; the placeholder still shows and nothing is emitted on render. CONTROLS: a required enum on each path offers no None item; in a grid repeater a required column offers none while an optional one does; a scalar list element offers none.
• inspectors/fallbackFormPatch-29733.test.tsx (new, 4): the helper through a merge leaves a cleared key absent and an edited key at its new value; CONTROL: untouched keys pass through and nothing becomes undefined; the real ActionDefaultInspector under a merging host: "— None —" on openIn and an emptied description each leave the draft without the key, with the curated keys untouched.
• Ablations (scripts/ablation-replace.mjs, each restored to the HEAD blob with git diff HEAD empty): A1 offerUnset forced false, 4 of 8 red (the three positive pins and the grid optional column), the 4 controls green. A2 the helper's undefined-for-dropped-key line removed, 3 of 4 red, the control green.
• Touched suites, under the verify lock at --maxWorkers=2: the 144 ui test files that name SchemaForm, one of the five inspectors or engine.form.none (git grep -l), 1464 tests, all green.

Acceptance notes

• The card's named door is not reachable in Studio today (measured). The Studio object designer's field panel (ObjectFieldInspector) offers no Delete Behavior row on a user field nor on a lookup field; the deleteBehavior rows live in object.form.ts / field.form.ts, which SchemaForm renders, and for object the editor shows the designer and its inspectors instead. So the named consequence (a cascade or restrict left in force on a user field) is prevented here for the moment a form that renders those rows is reached. The missing row in the designer's field panel is filed by the seat as its own finding.
• Surface: widened by claim amendment 6595600429 to the five default-inspector onChange call sites and one helper, after the live run showed a None item alone would be a dead control there. Clearing a text box or a number box in those fallback forms is fixed by the same change.
• Defaults: an enum whose schema carries a default is listed in the served schema's required and so offers no None item (hook onError, runAs). That is the existing required signal, not changed here.
• Not changed: the action inspector's own curated variant select (an InspectorSelectField, not SchemaForm) still has no unset item; it is outside this card.
• Narrowing declared: the full packages/app-shell suite is CI's (Test UI); locally the 144-file grep set above ran.

Verification

Real backend (examples/app-crm, objectstack dev --fresh) and the source Console (Vite on ui/apps/console), admin session, a scratch package with an object udb_ticket (a user field assignee, a lookup field parent_ticket) and an action udb_escalate (type: url, openIn: self). Screenshots are in the project folder (issue-29733/), not on GitHub.

🤖 Generated with Claude Code

Generated by Claude Code