Repository navigation
docs(pm-dispatch): docs-only ADR cards dispatch at CONTRACT_REVIEW_TIER + xhigh by standing order - #29850
Conversation
…igh by standing order execution-duties.md 〈派发〉: fold the maintainer's standing order into 条款① — a docs-only `docs/adr/**` card dispatches at the contract-review tier with effort `xhigh` fixed, with no per-card ask — and list ADR under `xhigh` on the effort line so the floor for every other ADR card stays where it was. Net zero lines (file at its 188-line ceiling); both rewritten lines sit at 120 bytes. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WGufzir9DwLT7sHJkBootW
Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WGufzir9DwLT7sHJkBootW
|
domain:skills#3 · os-support-ai · session_01WGufzhd2Ad9ANGTyAMW7pH Contract reviewServed-tier: Inputs read: card #29741 body and all three comments (triage audit 6595070364, claim 6597637142, os-dev-report 6597914303); PR #29850 body, file list (one file, +2/-2) and Check-runs on the head (conclusions are the gate verdicts): all 23 non-skipped runs ① Derived judgments
② Semver level
③ Boundary flagsos-dev-report 6597914303 lists three deviations and no
No boundary needs escalation to the maintainer: the standing order is the maintainer's own word (option A 「fable + xhigh,立为常设令」 then 「这个应该立卡更新 skills」), and the PR records it without widening tier, effort or the one-line-exit policy. ④ Design judgmentJudged file: Does the rewritten 条款① still carry everything the old line said?
Is the standing order bounded as the card asks?
Does line 122's change widen anything it should not?
Tried to break it, no must-fix found: no card class loses its CONTRACT_REVIEW_TIER mandate; no Findings:
Implemented-by: VERDICT: PASS |
…uling excepted 条款① now says the standing order covers ADR revisions (an amendment note, a wording fix, an `Amended by` entry) and that a new ruling, which a superseding ADR is, stays on the existing routes. Same line, 119 bytes, net zero. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WGufzir9DwLT7sHJkBootW
|
domain:skills#3 · os-support-ai · session_01WGufzhd2Ad9ANGTyAMW7pH Contract reviewServed-tier: Round: r1, a delta review on the head that applied should-fix 1 of the r0 record (PR comment 6598056150, head 6462193). Inputs read: card #29741 body and all three comments (no comment newer than the os-dev-report 6597914303); PR #29850 body as it stands, its file list (one file, +2/-2) and the net diff against Check-runs on the head (conclusions are the gate verdicts): all 23 non-skipped runs ① Derived judgments
② Semver level
③ Boundary flagsNo new os-dev-report on the card for r1; the three deviations of report 6597914303 stand as answered in the r0 record (attribution link: accepted; no PR subscription / reviewer request: the rule per dispatch-runbook.md 140; line 122 wording moved to fit 120 bytes: accepted, no meaning change).
No boundary needs escalation to the maintainer: the standing order is the maintainer's own word (option A 「fable + xhigh,立为常设令」, then 「这个应该立卡更新 skills」), and the head records it with a narrower scope than r0, not a wider one. ④ Design judgmentJudged file: Is r0 should-fix 1 closed? Yes.
Does the rewritten 条款① still carry everything the old line said? Unchanged from r0 and re-judged on this head:
Does line 122's change widen anything it should not? No — unchanged since r0: Tried to break it, no must-fix found: no card class loses CONTRACT_REVIEW_TIER; no Findings:
Implemented-by: VERDICT: PASS |
|
domain:skills#3 · os-support-ai · session_01WGufzhd2Ad9ANGTyAMW7pH 维护者速读
席位意见:常设令已记入规则,新裁决的边界也写在同一行,同意落地。 席位核对 — ACCEPT · domain:skills#3 · head
|
Requested by Yibo Wang · project thread
Fixes #29741
Clause-②: no
Metadata-protocol: none
Rules text only. Two lines of
.claude/skills/pm-dispatch/references/execution-duties.md〈派发〉 are rewritten in place; nothing published moves (skip-changeset).维护者速读
Amended by条目)走契约复审档、effortxhigh,凭常设令,不再逐卡问;新裁决除外」;effort 表把 ADR 列进xhigh档,max仍凭点名。xhigh地板由 effort 表接住,没有降档。execution-duties.md第 101 行(条款①)与第 122 行(effort 表),diff 只有这两行。pnpm check:pm-skill-ratchet && pnpm check:pm-skill-id-lint,预期两条都 ✓(文件仍 188 行,第 101 行 119 字节、第 122 行 120 字节)。.claude/**内)。What changes
One file, two lines, net zero lines. The file sits at its 188-line ratchet ceiling, so each rewritten line had to carry the new rule inside the 120-byte line cap on its own; no other line was re-wrapped to buy room.
What each line now says:
docs/adr/**⇒ CONTRACT_REVIEW_TIER; 「凡…的卡一律」 shortened to 「…即」). The effort half is the standing order: an ADR revision card (ADR 修订: an amendment note, a wording fix, anAmended byentry) takes effortxhighby 常设令, so the seat does not ask per card (neither a chat question nor a decision card); 新裁决除外 keeps a card that needs a new ruling, a superseding ADR included, outside the order.ADRjoins thexhighlist, so thexhighfloor that line 101 used to state for everydocs/adr/**card (mixed ADR + code, a superseding ADR, a card that needs a new decision) still holds there, and the existing tailmax凭点名 keepsmaxon an ADR card a named per-card word. To fit/ADRinside 120 bytes:securitylost its backticks (its neighbourp1never had them) and 「凭点名或常设令」 became 「凭点名/常设令」 (the same separator the list already uses).Outside the order, nothing moves: a card that needs a new decision still goes to a decision thread, a superseding ADR or an ADR + code diff keeps the existing routes (CONTRACT_REVIEW_TIER,
xhighfrom the effort table, split per the existing rules). The words ADR 修订 and 新裁决除外 carry that boundary (patch round 1, after the at-tier review's should-fix: the first wording 纯文档 ADR … 免逐卡问 left a superseding ADR inside the order by its wording).Provenance (maintainer, date) is deliberately not in the rule text:
check-skill-id-lint's header says the scanned corpus carries rules only and provenance lives in the PR that landed it, which is this one (Warren, 2026-11-03T03:05Z, option A 「fable + xhigh,立为常设令」, then 「这个应该立卡更新 skills」). The claim template'sreason:clause already names 常设档位令; after this lands a seat cites this card's number there.Why
The text fixed the tier and an effort floor but not the effort itself, and named a 常设令 only as a way to reach
max. A seat dispatching a one-paragraph ADR edit read that as a per-card maintainer call and waited on a decision thread for an answer the rule already implied. The standing order removes that round trip; this PR records it where seats read.Tests
None owed: prose in a
.claude/**reference file, no code or test moved. The two skill gates that judge this file are in the Verification section.Acceptance notes
grep -n 维护者near 档/effort/模型 inSKILL.mdanddispatch-runbook.md: SKILL.md line 311 (claim templatereason:already names 常设档位令) and line 275 (director tier, unrelated); dispatch-runbook.md line 137 says 「档位与 effort 席位自推导 ⛔ 不等维护者原话」. Neither repeats a per-card ask, so no mirror edit; the order file predicted the same.Verification
pnpm check:pm-skill-ratcheton 3c7c757 and 6462193: ✓ (execution-duties.md 188 lines at ceiling 188; line-byte check clean).pnpm check:pm-skill-id-linton 3c7c757 and 6462193: ✓ 109 file(s) clean.node scripts/pm/dispatch-gates.mjs --commands --repo objectstack-ai/objectstackderived 17 commands for the one changed path (merge base 42ff86f); each run serially, exit codes captured before any pipe, then--ran: 17 derived, 17 run, 0 NOT-MEASURED, exit 0 (check:doc-formula-expressionsfirst exited 3 on a missing@objectstack/lintdist; afterturbo run build --filter=@objectstack/formula --filter=@objectstack/lintit exited 0). All on 3c7c757;origin/mainthen moved (c5ddbea, no pm-dispatch or gate-script file touched) and was merged as 6462193, where--commandsderives the same 17 andcheck:pm-skill-ratchet+check:pm-skill-id-lintre-ran ✓.pnpm check:pm-skill-ratchetexit 0,pnpm check:pm-skill-id-lintexit 0.Human Minimum
Each item is one rule from
CONTRIBUTING.md › Human Minimum,
which links the AGENTS.md text that states it.
packages/specholds no runtime logic. (not touched)pnpm lintis CI's run (repo-level scan).main, one pull request..claude/**is not published:skip-changeset)packages/spectouched: its generated artifacts are regenerated and committed. (not touched)content/docs/references/,packages/*/CHANGELOG.mdorcontent/docs/releases/.Generated by Claude Code