fix(app-shell): publish review sheet lists no Options change on a picklist-bound field nobody edited - #29949

Requested by Yibo Wang · project thread

Fixes #29899

维护者速读

• 改了什么： Studio 发布审阅面板在比较对象的已发布版和草稿时，把绑定了 picklist 的字段都按"存储形"（不带 options）来比，不再把服务端解析出来的选项当成作者改动。
• 为什么改： 只要对象里有绑定 picklist 的字段，每次发布面板都会多出一行"~ Tier · Options"，作者根本没改过，面板失去可信度，真改了也分辨不出来。
• 风险与回滚： 只动 @object-ui/app-shell 的面板 diff，不改任何写入、协议或存储；只影响声明了 picklist 的字段的 options 比较。回滚即 revert 本 PR。
• 先看： ui/packages/app-shell/src/preview/DraftChangesPanel.tsx 的 computeChangeDetail 开头的 stored(...) 两行；新测试 DraftChangesPanel.picklistServedOptions-29899.test.tsx。
• 两分钟验证： pnpm --dir ui exec vitest run packages/app-shell/src/preview/__tests__/DraftChangesPanel.picklistServedOptions-29899.test.tsx，预期 3 passed。
• 需要你做的： 无，席位落地。

Clause-②: no
Metadata-protocol: none

What changes

computeChangeDetail (the diff behind Studio's publish review sheet) now reads both versions of an object in the form the publish door stores a picklist-bound field: without options. It does so by passing each envelope-free body through dropServedPicklistOptions from @object-ui/data-objectstack, the function the Studio and Setup writers already use to turn a served object read back into the authored form before a PUT (objectui#10202, objectui#11692). The step runs only when the entry's type is object.

The panel already imports from @object-ui/data-objectstack (readDraftChanges), so the console's eager graph gains no new module.

Why "compare like with like (both stored)" and not "skip options in the diff"

The card offered both. Normalizing to the stored form keeps every real change visible; skipping a key would hide some.

• dropServedPicklistOptions touches a field only when that definition names a picklist (picklist !== undefined, the FieldSchema refinement's own test). A field with inline options is returned by reference, so a real options change there is still listed. The CONTROL test proves it.
• A field moving between a picklist and inline options still lists both picklist and options, in either direction, because the side with inline options keeps them. A diff-level "ignore options when the field declares picklist" rule would hide the options half of that move. It would also have to choose which side's picklist counts.
• The authoring door refuses picklist and options together, so the stored form of a bound field never carries options. Normalizing to it loses nothing an author could have written.

Mechanism, measured against origin/main at 21510bba

The card's PM assumptions hold:

• The live read carries the resolved options; the draft read does not. readMetaItem (packages/metadata-protocol/src/protocol-meta-item-reads.ts) returns early for state: 'draft' ("Draft reads stop here"). It serves the converted draft row through governServedObject and never reaches the object fold. The active read folds the object through foldObjectExtendersFromRegistry → SchemaRegistry.foldObjectExtendersOnto → finishServedObject → resolvePicklistFieldsOnto (packages/objectql/src/picklist-resolution.ts). That last step writes the resolved options onto each bound field and keeps picklist.
• No path found where the draft itself carries resolved options. Studio's writers drop them before a save (dropServedPicklistOptions), and the authoring door refuses a body that carries both keys. A body that did carry both would also be normalized here on both sides.
• The fix is not server-side. Serving the resolved options on a bound field is the declared contract (PicklistServedFieldSchema, @objectstack/spec data/picklist.zod.ts): every object read serves it, and the write door judges values by the same served field. The draft read serving the stored row is ADR-0005's draft lifecycle. Neither read is wrong. The diff was comparing two forms, so the ui lane owns the fix.

Tests

New file ui/packages/app-shell/src/preview/__tests__/DraftChangesPanel.picklistServedOptions-29899.test.tsx. It renders the real DraftChangesPanel against routes where the published read serves tier with resolved options and the draft read serves it stored:

1. A picklist-bound field tier, and a draft that changes only notes.label: the drill-in renders exactly one row, ~ Again notes notes · Label, and no Options.
2. CONTROL: an inline-options select status whose options really changed, beside the same bound tier: exactly one row, ~ Status status · Options.
3. computeChangeDetail direct: a bound field reads unchanged; bound → inline and inline → bound each list both picklist and options; the array fields shape reads the same.

ablation-replace: ok mutation landed: anchor 1 -> 0, blob 694ec6852677 -> eb00fb8b831c
     × lists only the label change when the draft edits another field of an object with a bound field
     × CONTROL: still lists an Options change on a field with inline options
     × reads a bound field as unchanged in computeChangeDetail, and keeps a move to or from inline options
AssertionError: expected [ '~ Again notes notes · Label', …(1) ] to have a length of 1 but got 2
AssertionError: expected [ '~ Status status · Options', …(1) ] to have a length of 1 but got 2
AssertionError: expected [ { name: 'tier', …(1) } ] to deeply equal []
 Test Files  1 failed (1)
      Tests  3 failed (3)
ablation-replace: ok restored: blob == HEAD (694ec6852677) and `git diff HEAD` is empty

Acceptance notes

• Scope: this changes only what the review sheet displays. The publish door's own no-op test (content hashes of the stored bodies) never read served options and is unchanged.
• type gate: only object bodies are normalized. Its one caller passes entry.type. The served picklist form is a property of object reads.
• No out-of-scope findings.

Verification

All runs at head f4d64a21, from the ui/ root as ui/AGENTS.md prescribes, under scripts/pm/os-verify-lock.sh.

node scripts/check-adr-0087-registration.mjs --base origin/main :: exit 0
node scripts/check-adr-0087-registration.mjs --self-test :: exit 0
node scripts/check-changeset-no-major.mjs --base origin/main :: exit 0
node scripts/check-closing-keyword-parity.mjs :: exit 0
node scripts/check-closing-keyword-parity.mjs --self-test :: exit 0
node scripts/check-comment-mask-corpus.mjs :: exit 0
node scripts/check-empty-changeset.mjs --base origin/main :: exit 0
node scripts/check-empty-changeset.mjs --self-test :: exit 0
node scripts/check-sdui-manifest.mjs :: exit 0
node scripts/check-sdui-manifest.mjs --self-test :: exit 0
node scripts/pm/release-rehearsal-clone.mjs --self-test :: exit 0
node scripts/release-pending-publish.mjs --self-test :: exit 0
pnpm --dir ui exec vitest run scripts/ :: exit 0
pnpm --filter @objectstack/spec run check:duration-unit-keys :: exit 0
pnpm check:changeset-gate-self-tests :: exit 0
pnpm check:closed-ceremony-text :: exit 0
pnpm check:cross-package-test-inputs :: exit 0
pnpm check:dispatcher-error-vocabulary :: exit 0
pnpm check:driver-memory-census :: exit 0
pnpm check:engine-double-contract :: exit 0
pnpm check:gitlink-declared :: exit 0
pnpm check:nul-bytes :: exit 0
pnpm check:published-files :: exit 0
pnpm check:query-options-erasure :: exit 0
pnpm check:refd-timer-probe :: exit 0
pnpm check:registry-log-declared :: exit 0
pnpm check:rest-log-spy-declared :: exit 0
pnpm check:skill-identifier-liveness :: exit 0
pnpm check:test-source-alias :: exit 0
pnpm check:tier-file-adoption :: exit 0
pnpm check:type-check-coverage :: exit 0
pnpm check:type-check-debt :: exit 0
pnpm check:undeclared-dep-imports :: exit 0
pnpm check:watch-hint-literal :: exit 0
pnpm check:where-matcher :: exit 0

🤖 Generated with Claude Code

https://claude.ai/code/session_01WGufzfC4w4tZzdzVyV5FGX