feat(plugin-list): a reader can add any field they may read to their own list (#30077) - #30162

domain:ui#2 · os-justin · session_01QSeKYnE9YNkSZen7sijLA3

Fixes #30077

Clause-②: no
Metadata-protocol: none

维护者速读

• 改了什么：列表的「隐藏字段」面板（工具栏的和「显示」面板里的同一节）在视图自带的列之后，列出该对象里读者有权读取的其余字段，默认不勾选；勾选就把它加成读者自己列表里的一列，取消勾选就拿掉。
• 为什么改：按本卡裁决 A（「其他全部同意」），业务员想在自己的列表里看负责人、折扣等字段时，不必再请管理员替全公司改视图。
• 风险与回滚：只存在读者个人偏好里（sys_user_preference 的 ui.list.OBJECT 行新增 addedFields），不写视图、不改元数据和 spec；回滚即 revert，旧版本的清洗函数会丢掉 addedFields，没有残留副作用。
• 先看：ui/packages/plugin-list/src/ListView.tsx（addableFields 的取数与 updateListedFields 里「取消勾选已加列」的分支）；ui/packages/app-shell/src/views/objectViewListRenderer.tsx（withAddedListColumns 与 columns 那一级的拼接）；ui/packages/app-shell/src/context/ListPreferencesProvider.tsx（addedFields 的清洗）。
• 两分钟验证：pnpm --dir ui exec vitest run packages/plugin-list/src/__tests__/ListView.fieldListRead-11984.test.tsx packages/app-shell/src/views/ObjectView.userListState-12418.test.tsx，预期两个文件全部通过。
• 需要你做的：无，席位落地。

What changes

• The offer (@object-ui/plugin-list). Two new ListView host props: addedFields (the names among schema.columns the reader added) and onAddedFieldsChange (the door that stores them). When the door is wired, both hide-fields lists — the wide toolbar's Hide fields popover and the Hide Fields section of the Display panel (ViewSettingsPopover, the same door: it writes through the same updateHiddenFields callback) — list, after the view's columns, every other field of the object's definition that the caller may read (canReadField, the predicate every toolbar field list asks), that the definition does not mark hidden: true, and that is not already a column; business fields first, then system fields (isSystemManagedField), unticked. Ticking one calls onAddedFieldsChange with the whole new list; unticking an added column calls it without that name instead of hiding it; adding a name a stale hidden entry carries clears that entry too. A reader-added column is labelled from the definition in the popover. Without the door the popover is byte-for-byte today's.
• The store (@object-ui/app-shell). ListViewPreference gains addedFields beside hiddenFields in the reader's ui.list.OBJECT row: sanitized to unique names, and an empty list is dropped (nothing added is the view's own). "Reset to view" removes it with the rest of the view's entry (resetViewPreference), unchanged code path.
• The host (objectViewListRenderer). withAddedListColumns appends the stored added names to the columns rung in the view's own column shape (bare names beside bare names, { field } beside column objects), skipping any name the view itself declares; the list therefore fetches ($select), expands ($expand, through buildExpandFields over schema.columns) and draws an added column exactly as a declared one. The door is wired where a Hide Fields choice is stored (a view that declares columns, or a saved view); on a system view or fallback tab that declares no columns it is not wired, matching the session-only hide there.
• The marker (objectViewListUrlState). A stored addedFields reports the existing columns part, so the Personalized marker draws and names "Column layout" with no new copy.
• ui/packages/plugin-list/README.md documents the two host props (ui/AGENTS.md ✨ Set up Copilot instructions #2).

Tests

All runs on this branch's worktree, under scripts/pm/os-verify-lock.sh; head at the final run: 916241ae1.

• New pins, ListView.fieldListRead-11984.test.tsx (top-level describe, objectstack#30077): wide and compact, restricted caller is offered Title, Status, Priority and not the two unreadable fields; full-read control offers them; door absent offers the view's columns alone; tick adds through the door and leaves hide/show of a view column unchanged; untick of an added column removes it and writes no hidden list; a stale hidden entry is cleared on add; the Display panel adds through the same door; a hidden: true field is not offered and system fields follow business fields; an added lookup is in the next $select and $expand.
• New pins, ObjectView.userListState-12418.test.tsx (top-level describe): adding writes no view and lands as one save of addedFields; the list is handed the column appended; a fresh browser opens with it; another user does not see it; "Reset to view" drops it (the stored addition alone draws the marker); a name the view declares is not duplicated; a saved view that declares columns stores it the same way.
• New pins, ListPreferencesProvider.slot-12418.test.ts: sanitize, patch/clear and reset of addedFields.

Acceptance notes

• File surface. The claim named the store path under ui/packages/app-shell/src/views/**; the store is ui/packages/app-shell/src/context/ListPreferencesProvider.tsx (its sanitizer drops any undeclared part, so an added list cannot persist without it). objectViewListUrlState.ts (under views/**) carries the marker part. ui/packages/plugin-list/README.md is added for ui/AGENTS.md ✨ Set up Copilot instructions #2.
• Lookup columns (card "Not measured"). No server change needed: $expand is built from schema.columns by buildExpandFields, so an added lookup is expanded as a declared one; pinned. No field type is excluded from the offer.
• Where it is not offered. A system view or fallback tab that declares no columns (its hide is session-only by ruling 5839344270 on objectui#10694), and every host that does not wire onAddedFieldsChange (InterfaceListPage, page blocks).
• Copy unchanged. The trigger still reads "Hide fields" and the section "Hide Fields"; the marker reports added fields as "Column layout", and the reset sentence already names "column layout". The Display trigger's count does not count added fields. Renaming the control would touch ten locale packs and is left as a note, not filed.
• Shared list. The Group editor and Row color select read the same allFields, so they also list a column the reader added (it is a column of their list); they never list a field not on the list.
• Query width. An added column widens $select by one field; the page size and existing caps are unchanged.
• Grid header of an added column was not measured in a browser: this harness does not render the lazily registered grid. The popover label is pinned.

Verification

Browser check

Real Chromium (Playwright, real clicks and real typing), head 916241ae1. Example CRM backend (objectstack dev --seed-admin --fresh -p 4377 in examples/app-crm), Console built from this branch's ui/ source (vite --port 5377 --strictPort, DEV_PROXY_TARGET=http://localhost:4377), locale en-US, signed in as the seeded admin, on Opportunities / All Opportunities (crm_opportunity.all). The organization's first-run "Set the default currency" dialog was answered once. 14 of 14 assertions passed. The screenshots are kept in the seat's scratchpad, not uploaded; the seat viewed 04-grid-added.png and 11-labels.png.

1. List opens on the view's columns. Headers: Opportunity Name, Account, Stage, Deal Value, Win Probability (%), Expected Revenue, Expected Close. PASS
2. Offered unticked. In Display, Hide Fields, Owner (owner_id, a lookup) and Days to Close (a formula field) are listed after the view's columns, unticked. Discount (%), Approval Status, Renewal Of and Products Total are offered too. PASS
3. Tick both. The grid header gains Owner and Days to Close. Owner cells read "Dev Admin" (the lookup's display name, not the id) and Days to Close cells carry values. The reader's preference ui.list.crm_opportunity reads perView.crm_opportunity.all.addedFields = ["owner_id","days_to_close"]. PASS
4. Reload. Both columns are still there. PASS
5. Reset to view. The Personalized marker names "Column layout". After the reset both columns are gone and the stored row is {}. PASS
6. Untick an added column. Days to Close goes back to the add list unticked; the stored row is addedFields = ["owner_id"] with no hiddenFields. After a reload it is still absent and still offered, so it was removed, not hidden. PASS

Rework round 2: labels (head cfcc48813). The first run listed two of the view's own label-less columns under their machine names (account, expected_revenue) while the grid header read Account and Expected Revenue. allFields in ListView.tsx now falls back to the object definition's field label for every column with no label of its own. Order: translation, then the column's own label, then the definition's label, then the field name.

7. Labels. Hide Fields lists Opportunity Name, Account, Stage, Deal Value, Win Probability (%), Expected Revenue, Expected Close, equal item for item to the grid header row. 3 of 3 assertions passed. PASS

Pin: ListView.fieldListRead-11984.test.tsx, "a column with no label of its own is listed under the definition's label, not its machine name"; ablated red (expected [ 'title', 'status', 'Priority ] to include 'Status'), restored green. The Group and Row color pickers share this list; the one pin that spelled the old raw name (ListView.rowColorSelect-12376.test.tsx, subject → Subject) was updated with its intent unchanged.

Not changed here: the list puts a translation before a column's own label, while the grid header puts the column's own label first and prettifies a bare name. They agree whenever a column has no label, which is the case fixed here.

Generated by Claude Code