Repository navigation
Fix protocol method signatures in plugin-hono-server and plugin-msw - #413
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update action step in job configuration
Fix protocol method signatures in plugin-hono-server and plugin-msw
Jan 31, 2026
hotlong
marked this pull request as ready for review
January 31, 2026 01:08
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes protocol method signatures in two plugins (plugin-hono-server and plugin-msw) to align with a recent refactor that changed the protocol interface from individual parameters to structured request objects.
Changes:
- Updated 16 protocol method calls in
plugin-hono-serverto use object parameters - Updated 11 protocol method calls in
plugin-mswto use object parameters - Adjusted logging statements to correctly access nested properties in new response structures (e.g.,
result.records.lengthinstead ofresult.length) - Added
asynckeywords to handlers that now await protocol methods that may have become asynchronous - Removed unnecessary
@ts-ignorecomment that is no longer needed with correct typing
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/plugins/plugin-hono-server/src/hono-plugin.ts | Updated all 16 protocol method calls to use structured request objects (e.g., { object, query } instead of separate parameters) and corrected logging to access nested response properties |
| packages/plugins/plugin-msw/src/msw-plugin.ts | Updated all 11 protocol method calls to use structured request objects and adjusted logging statements to match new response structure with records array |
This was referenced Oct 27, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Protocol interface changed from individual parameters to structured request objects in recent refactor. Plugins were still using old signatures.
Changes
Updated protocol method calls to use object parameters:
Before:
After:
Affected Files
packages/plugins/plugin-hono-server/src/hono-plugin.ts- 16 method callspackages/plugins/plugin-msw/src/msw-plugin.ts- 11 method callsAll changes follow the same pattern: individual parameters → destructured request object.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.