[WIP] Fix issue in job step execution by Copilot · Pull Request #433 · objectstack-ai/objectstack

Copilot · 2026-01-31T05:11:05Z

Fix TypeScript Compilation Errors in examples/basic

Analyze compilation errors from CI build
Check missing exports in spec packages (API, Hub, System, Integration)
Add missing type exports to spec package index files
- Added ODataConfig, RealtimeConfig, BatchConfig to API module
- Added MarketplaceListing, Space, ComposerConfig aliases to Hub module
- Added JobSchedule alias to System module
- Added SaaSConnector alias to Integration module
- Added integration and permission exports to package.json
Fix incorrect type usages in example files (passthrough schemas)
Verify all changes with build
Run tests to ensure no regressions

Original prompt

引用: https://github.com/objectstack-ai/spec/actions/runs/21539241828/job/62070937605#step:8:1

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

vercel · 2026-01-31T05:11:09Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
spec	Ready	Preview, Comment	Jan 31, 2026 5:28am

Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>

Copilot

Pull request overview

This PR adds missing type exports and configuration schemas to fix TypeScript compilation errors in the examples/basic package. The changes introduce new configuration schemas for API modules (OData, Realtime, Batch) and add backwards-compatible type aliases across multiple modules (Hub, System, Integration).

Changes:

Added package.json exports for integration and permission modules
Added type aliases for backwards compatibility (JobSchedule, SaaSConnector, Space, MarketplaceListing, ComposerConfig)
Added new configuration schemas (ODataConfig, RealtimeConfig, BatchConfig) with corresponding JSON schemas and documentation

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 9 comments.

Show a summary per file

File	Description
packages/spec/package.json	Added exports for integration and permission modules
packages/spec/src/system/job.zod.ts	Added JobSchedule type alias for backwards compatibility
packages/spec/src/integration/connector/saas.zod.ts	Added SaaSConnector type alias for alternative capitalization
packages/spec/src/hub/space.zod.ts	Added Space type alias for backwards compatibility
packages/spec/src/hub/marketplace.zod.ts	Added MarketplaceListing type alias for backwards compatibility
packages/spec/src/hub/composer.zod.ts	Added ComposerConfig type alias for configuration context
packages/spec/src/api/realtime.zod.ts	Added RealtimeConfigSchema for realtime API configuration
packages/spec/src/api/odata.zod.ts	Added ODataConfigSchema for OData API configuration
packages/spec/src/api/batch.zod.ts	Added BatchConfigSchema for batch operations configuration
packages/spec/json-schema/api/RealtimeConfig.json	Generated JSON schema for RealtimeConfig
packages/spec/json-schema/api/ODataConfig.json	Generated JSON schema for ODataConfig
packages/spec/json-schema/api/BatchConfig.json	Generated JSON schema for BatchConfig
content/docs/references/api/realtime.mdx	Updated documentation with RealtimeConfig schema
content/docs/references/api/odata.mdx	Updated documentation with ODataConfig schema
content/docs/references/api/batch.mdx	Updated documentation with BatchConfig schema

Copilot · 2026-01-31T05:26:52Z

+
+  /** Default subscriptions */
+  subscriptions: z.array(SubscriptionSchema).optional().describe('Default subscriptions'),
+}).passthrough(); // Allow additional properties


The use of .passthrough() here is inconsistent with the rest of the codebase. No other schemas in the spec package use .passthrough() or .strict(), relying instead on Zod's default .strip() behavior.

Using .passthrough() on configuration schemas can lead to:

Silent acceptance of typos in configuration keys

Difficulty in catching configuration errors at validation time

Inconsistency with established patterns in the codebase

Consider removing .passthrough() to align with the codebase conventions. If additional properties are genuinely needed for extensibility, this should be documented and applied consistently across all configuration schemas, or handled through a more explicit mechanism like an extensions or metadata field.

Copilot · 2026-01-31T05:26:52Z

+export const ODataConfigSchema = z.object({
+  /** Enable OData endpoint */
+  enabled: z.boolean().default(true).describe('Enable OData API'),
+
+  /** OData endpoint path */
+  path: z.string().default('/odata').describe('OData endpoint path'),
+
+  /** Metadata configuration */
+  metadata: ODataMetadataSchema.optional().describe('OData metadata configuration'),
+}).passthrough(); // Allow additional properties for flexibility
+
+export type ODataConfig = z.infer<typeof ODataConfigSchema>;


The new ODataConfigSchema lacks test coverage. The odata.test.ts file has comprehensive tests for other schemas in odata.zod.ts, but no tests have been added for the new ODataConfigSchema.

Consider adding tests to verify:

Default values (enabled=true, path='/odata')

Optional metadata field

Integration with ODataMetadataSchema

Copilot · 2026-01-31T05:26:53Z

+export const RealtimeConfigSchema = z.object({
+  /** Enable realtime sync */
+  enabled: z.boolean().default(true).describe('Enable realtime synchronization'),
+
+  /** Transport protocol */
+  transport: TransportProtocol.default('websocket').describe('Transport protocol'),
+
+  /** Default subscriptions */
+  subscriptions: z.array(SubscriptionSchema).optional().describe('Default subscriptions'),
+}).passthrough(); // Allow additional properties
+
+export type RealtimeConfig = z.infer<typeof RealtimeConfigSchema>;


The new RealtimeConfigSchema lacks test coverage. The realtime.test.ts file has comprehensive tests for other schemas in realtime.zod.ts, but no tests have been added for the new RealtimeConfigSchema.

Consider adding tests to verify:

Default values (enabled=true, transport='websocket')

Optional subscriptions field

Integration with SubscriptionSchema and TransportProtocol

Copilot · 2026-01-31T05:26:53Z

+
+  /** Metadata configuration */
+  metadata: ODataMetadataSchema.optional().describe('OData metadata configuration'),
+}).passthrough(); // Allow additional properties for flexibility


The use of .passthrough() here is inconsistent with the rest of the codebase. No other schemas in the spec package use .passthrough() or .strict(), relying instead on Zod's default .strip() behavior.

Using .passthrough() on configuration schemas can lead to:

Silent acceptance of typos in configuration keys

Difficulty in catching configuration errors at validation time

Inconsistency with established patterns in the codebase

Consider removing .passthrough() to align with the codebase conventions. If additional properties are genuinely needed for extensibility, this should be documented and applied consistently across all configuration schemas, or handled through a more explicit mechanism like an extensions or metadata field.

Copilot · 2026-01-31T05:26:53Z

+
+  /** Default options */
+  defaultOptions: BatchOptionsSchema.optional().describe('Default batch options'),
+}).passthrough(); // Allow additional properties


The use of .passthrough() here is inconsistent with the rest of the codebase. No other schemas in the spec package use .passthrough() or .strict(), relying instead on Zod's default .strip() behavior.

Using .passthrough() on configuration schemas can lead to:

Silent acceptance of typos in configuration keys

Difficulty in catching configuration errors at validation time

Inconsistency with established patterns in the codebase

Consider removing .passthrough() to align with the codebase conventions. If additional properties are genuinely needed for extensibility, this should be documented and applied consistently across all configuration schemas, or handled through a more explicit mechanism like an extensions or metadata field.

Copilot · 2026-01-31T05:26:53Z

 export type CronSchedule = z.infer<typeof CronScheduleSchema>;
 export type IntervalSchedule = z.infer<typeof IntervalScheduleSchema>;
 export type OnceSchedule = z.infer<typeof OnceScheduleSchema>;
+export type JobSchedule = Schedule; // Alias for backwards compatibility


There's a discrepancy between the PR title "[WIP] Fix issue in job step execution" and the actual changes, which are focused on adding missing type exports and configuration schemas to fix TypeScript compilation errors in examples/basic. The PR title should be updated to accurately reflect the changes being made, such as "Add missing type exports and config schemas to fix compilation errors".

Copilot · 2026-01-31T05:26:53Z


 // Validate data
-const result = ODataErrorSchema.parse(data);
+const result = ODataConfigSchema.parse(data);


The example code has been changed from parsing ODataErrorSchema to ODataConfigSchema. This change doesn't make sense in the context of the documentation - the example should demonstrate the primary use case of the API module. If ODataConfigSchema is more important, this is a reasonable change, but if ODataErrorSchema was the better example before, changing it just because a new schema was added is inconsistent.

Consider whether this change is intentional or if it should revert to the original example while still documenting the new ODataConfigSchema elsewhere in the file.

Suggested change

const result = ODataConfigSchema.parse(data);

const result = ODataErrorSchema.parse(data);

Copilot · 2026-01-31T05:26:54Z


 // Validate data
-const result = BatchOperationResultSchema.parse(data);
+const result = BatchConfigSchema.parse(data);


The example code has been changed from parsing BatchOperationResultSchema to BatchConfigSchema. This change doesn't make sense in the context of the documentation - the example should demonstrate the primary use case of the API module. If BatchConfigSchema is more important, this is a reasonable change, but if BatchOperationResultSchema was the better example before, changing it just because a new schema was added is inconsistent.

Consider whether this change is intentional or if it should revert to the original example while still documenting the new BatchConfigSchema elsewhere in the file.

Suggested change

const result = BatchConfigSchema.parse(data);

const result = BatchOperationResultSchema.parse(data);

Copilot · 2026-01-31T05:26:54Z

+export const BatchConfigSchema = z.object({
+  /** Enable batch operations */
+  enabled: z.boolean().default(true).describe('Enable batch operations'),
+
+  /** Maximum records per batch */
+  maxRecordsPerBatch: z.number().int().min(1).max(1000).default(200).describe('Maximum records per batch'),
+
+  /** Default options */
+  defaultOptions: BatchOptionsSchema.optional().describe('Default batch options'),
+}).passthrough(); // Allow additional properties
+
+export type BatchConfig = z.infer<typeof BatchConfigSchema>;


The new BatchConfigSchema lacks test coverage. The batch.test.ts file has comprehensive tests for all other schemas in batch.zod.ts, but no tests have been added for the new BatchConfigSchema.

Consider adding tests to verify:

Default values (enabled=true, maxRecordsPerBatch=200)

Min/max constraints on maxRecordsPerBatch

Optional defaultOptions field

Integration with BatchOptionsSchema

Initial plan

2e50c27

Copilot AI assigned Copilot and hotlong Jan 31, 2026

Copilot started work on behalf of hotlong January 31, 2026 05:11

View session

Add missing type exports for API, Hub, System, and Integration modules

dbc25a6

Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>

hotlong marked this pull request as ready for review January 31, 2026 05:20

Copilot AI review requested due to automatic review settings January 31, 2026 05:20

hotlong merged commit 91314b1 into copilot/update-examples-and-test-platform Jan 31, 2026
4 of 5 checks passed

Copilot started reviewing on behalf of hotlong January 31, 2026 05:21

View session

Copilot AI requested a review from hotlong January 31, 2026 05:21

Copilot stopped work on behalf of hotlong due to an error January 31, 2026 05:21
The session was cancelled by the user.

Copilot AI reviewed Jan 31, 2026

View reviewed changes

vercel Bot deployed to Preview January 31, 2026 05:28

View deployment

Navigation Menu

Repository navigation

[WIP] Fix issue in job step execution - #433

[WIP] Fix issue in job step execution#433
hotlong merged 2 commits into
copilot/update-examples-and-test-platformfrom
copilot/resolve-job-step-issue

Copilot AI commented Jan 31, 2026 •

edited

Loading

Uh oh!

vercel Bot commented Jan 31, 2026 •

edited

Loading

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jan 31, 2026

Uh oh!

Copilot AI Jan 31, 2026

Uh oh!

Copilot AI Jan 31, 2026

Uh oh!

Copilot AI Jan 31, 2026

Uh oh!

Copilot AI Jan 31, 2026

Uh oh!

Copilot AI Jan 31, 2026

Uh oh!

Copilot AI Jan 31, 2026

Uh oh!

Copilot AI Jan 31, 2026

Uh oh!

Copilot AI Jan 31, 2026

Uh oh!

This branch was successfully deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	const result = ODataConfigSchema.parse(data);
	const result = ODataErrorSchema.parse(data);

	const result = BatchConfigSchema.parse(data);
	const result = BatchOperationResultSchema.parse(data);

Conversation

Copilot AI commented Jan 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Fix TypeScript Compilation Errors in examples/basic

Uh oh!

vercel Bot commented Jan 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 31, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 31, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 31, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 31, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 31, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 31, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 31, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 31, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 31, 2026

Choose a reason for hiding this comment

Uh oh!

This branch was successfully deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Jan 31, 2026 •

edited

Loading

vercel Bot commented Jan 31, 2026 •

edited

Loading