Skip to content

Fix SimStore NumPy deprecations#1002

Merged
dwhswenson merged 2 commits into
openpathsampling:masterfrom
dwhswenson:simstore-numpy-deprecations
Apr 8, 2021
Merged

Fix SimStore NumPy deprecations#1002
dwhswenson merged 2 commits into
openpathsampling:masterfrom
dwhswenson:simstore-numpy-deprecations

Conversation

@dwhswenson

Copy link
Copy Markdown
Member

Removes some old tostring() calls that should be tobytes().

@codecov

codecov Bot commented Apr 6, 2021

Copy link
Copy Markdown

Codecov Report

Merging #1002 (ebd8e0b) into master (5f86032) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1002      +/-   ##
==========================================
- Coverage   80.62%   80.61%   -0.01%     
==========================================
  Files         138      138              
  Lines       14695    14695              
==========================================
- Hits        11848    11847       -1     
- Misses       2847     2848       +1     
Impacted Files Coverage Δ
openpathsampling/netcdfplus/cache.py 61.18% <0.00%> (-0.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f86032...ebd8e0b. Read the comment docs.

@dwhswenson

Copy link
Copy Markdown
Member Author

This is ready for review and comment. I will leave it open for at least 24 hours, merging no earlier than Wed 07 Apr 17:00 GMT (19:00 local).

@sroet sroet left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dwhswenson dwhswenson merged commit 9197e1e into openpathsampling:master Apr 8, 2021
@dwhswenson dwhswenson deleted the simstore-numpy-deprecations branch April 8, 2021 07:44
@dwhswenson dwhswenson mentioned this pull request Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants