Prevent netcdfplus from trying to load netcdfplus CVs as SimStore CVs#1003
Merged
dwhswenson merged 2 commits intoApr 9, 2021
Merged
Conversation
Member
Author
|
I have no idea why GHA isn't running this... going to close/reopen to see if that triggers a build. |
Codecov Report
@@ Coverage Diff @@
## master #1003 +/- ##
=======================================
Coverage 80.61% 80.61%
=======================================
Files 138 138
Lines 14695 14695
=======================================
Hits 11847 11847
Misses 2848 2848
Continue to review full report at Codecov.
|
Member
Author
|
This is ready for review and comment. I will leave it open for at least 24 hours, merging no earlier than Thu 08 Apr 16:00 GMT (18:00 local). (Forgot to add that once tests passed!) |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of #995, it appears that netcdfplus tries to load CVs as SimStore CVs. This is apparently because netcdfplus maps a class name (not fully qualified; just the class name) to a class. And once SimStore CVs were found in the chain of subclasses, netcdfplus replaced the old CVs with the new ones. This would lead to errors when loading old CVs (which do not have the same storage dict as new CVs).
The solution is to exclude classes in the
openpathsampling.experimental.storagesubpackage from being listed as classes that netcdfplus can load.