SimStore: Make storable function modes customizable#1004
Merged
dwhswenson merged 2 commits intoApr 10, 2021
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1004 +/- ##
==========================================
+ Coverage 80.61% 81.15% +0.53%
==========================================
Files 138 138
Lines 14695 15118 +423
==========================================
+ Hits 11847 12269 +422
- Misses 2848 2849 +1
Continue to review full report at Codecov.
|
Member
Author
|
This is ready for review and comment. I will leave it open for at least 24 hours, merging no earlier than Fri 09 Apr 12:00 GMT (14:00 local). |
sroet
requested changes
Apr 8, 2021
sroet
left a comment
Member
There was a problem hiding this comment.
1 unnecessary line of code, LGTM otherwise
Co-authored-by: Sander Roet <sanderroet@hotmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The definition of modes for storable functions in SimStore (i.e.,
'analysis','production','no-caching') was in a dictionary that was defined in the__call__method. This moves that dictionary to a private instance variable. This will allow (advanced) users to update that dictionary with custom modes.This also removes an unnecessary skip that was shadowing the fact that some tests needed to be updated for changes in #985. The previously skipped tests now run and pass.