MAX_SQL_ITEMS as class variable#1016
Merged
dwhswenson merged 3 commits intoJun 5, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1016 +/- ##
==========================================
+ Coverage 81.17% 81.27% +0.10%
==========================================
Files 139 139
Lines 15143 15149 +6
==========================================
+ Hits 12292 12313 +21
+ Misses 2851 2836 -15
Continue to review full report at Codecov.
|
Member
Author
|
I couldn't reproduce the error locally (I think because of the way my SQLite is compiled) but this fixed the error on the user end, and I did add tests that should, in principle, check for regression. So I'm going to go ahead and merge this. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This converts the
max_query_sizethat @sroet had introduced as an instance variable inSQLStorageBackendto a class variable, and adds its use in a corner case that @gyorgy-hantal came across.It makes more sense to have this as a class variable because it is determined by the way the SQL backend (usually SQLite) was compiled on the local machine, and therefore will be constant throughout a session (for however many files the user opens). Of course, it can still be overridden on an instance-by-instance basis.
Currently WIP because I'm hoping that I can get a regression test, but I may mark it as ready to merge without such a test if it is too annoying to create. @gyorgy-hantal has confirmed that this fixed his issue.