Fix bug in live visualizer setup with implicit hooks#1034
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1034 +/- ##
==========================================
+ Coverage 81.51% 81.54% +0.02%
==========================================
Files 140 140
Lines 15399 15400 +1
==========================================
+ Hits 12553 12558 +5
+ Misses 2846 2842 -4
Continue to review full report at Codecov.
|
This will check that setting sim.live_visualizer works.
Member
|
@hejung : I added a test to quiet the complaints from CodeCov (plus, this test actually covers the issue -- fails in old code, passes in new). Please take a look and see if there's anything you want to change in them. One I have your approval on that, this is ready to merge! |
Contributor
Author
|
perfect! |
dwhswenson
approved these changes
Jul 12, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1033