Skip to content

Fix OpenMM engine docs on n_frames_max#1037

Merged
dwhswenson merged 1 commit into
openpathsampling:masterfrom
hejung:#817
Jul 20, 2021
Merged

Fix OpenMM engine docs on n_frames_max#1037
dwhswenson merged 1 commit into
openpathsampling:masterfrom
hejung:#817

Conversation

@hejung

@hejung hejung commented Jul 20, 2021

Copy link
Copy Markdown
Contributor

Resolves #817
I looked through the issues I opened and realized that this one is a real low hanging fruit :)

@codecov

codecov Bot commented Jul 20, 2021

Copy link
Copy Markdown

Codecov Report

Merging #1037 (d297604) into master (e8b091c) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1037      +/-   ##
==========================================
- Coverage   81.55%   81.54%   -0.01%     
==========================================
  Files         140      140              
  Lines       15400    15400              
==========================================
- Hits        12559    12558       -1     
- Misses       2841     2842       +1     
Impacted Files Coverage Δ
openpathsampling/engines/openmm/engine.py 70.00% <ø> (ø)
openpathsampling/netcdfplus/cache.py 63.72% <0.00%> (-0.33%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8b091c...d297604. Read the comment docs.

@dwhswenson dwhswenson changed the title fix #817 Fix OpenMM engine docs on n_frames_max Jul 20, 2021
@dwhswenson dwhswenson added misc PR docs issues/PRs related to documentation labels Jul 20, 2021

@dwhswenson dwhswenson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely an easy fix! 😄 LGTM.

@dwhswenson dwhswenson merged commit f6351d4 into openpathsampling:master Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs issues/PRs related to documentation misc PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

openMM engine does not accept: n_frames_max=None

2 participants