Skip to content

improvements to unpatch after using SimStore#1065

Merged
dwhswenson merged 2 commits into
openpathsampling:masterfrom
dwhswenson:improve-simstore-unpatch
Sep 9, 2021
Merged

improvements to unpatch after using SimStore#1065
dwhswenson merged 2 commits into
openpathsampling:masterfrom
dwhswenson:improve-simstore-unpatch

Conversation

@dwhswenson

@dwhswenson dwhswenson commented Sep 9, 2021

Copy link
Copy Markdown
Member

There's an unpatch method in the monkey_patches to undo the patches that tell OPS that you'll be using SimStore. This generally isn't used by users (who tend to be either fully in SimStore or fully not, at least within a given session), but it is important for unit testing.

This PR adds some importlib.reload commands that are required to fully undo the patch.

@dwhswenson dwhswenson changed the title improvements to unpatch for using SimStore improvements to unpatch after using SimStore Sep 9, 2021
@codecov

codecov Bot commented Sep 9, 2021

Copy link
Copy Markdown

Codecov Report

Merging #1065 (3f0244f) into master (4ddecfd) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1065   +/-   ##
=======================================
  Coverage   81.57%   81.57%           
=======================================
  Files         140      140           
  Lines       15416    15416           
=======================================
  Hits        12576    12576           
  Misses       2840     2840           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ddecfd...3f0244f. Read the comment docs.

Comment thread openpathsampling/experimental/storage/monkey_patches.py Outdated

@sroet sroet left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dwhswenson dwhswenson merged commit a760afe into openpathsampling:master Sep 9, 2021
@dwhswenson dwhswenson deleted the improve-simstore-unpatch branch September 9, 2021 18:24
@dwhswenson dwhswenson mentioned this pull request Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants