Skip to content

Python versions should be strings in YAML#1081

Merged
dwhswenson merged 1 commit into
openpathsampling:masterfrom
dwhswenson:string-versions
Oct 9, 2021
Merged

Python versions should be strings in YAML#1081
dwhswenson merged 1 commit into
openpathsampling:masterfrom
dwhswenson:string-versions

Conversation

@dwhswenson

Copy link
Copy Markdown
Member

Reduce likelihood of mistakes when adding 3.10 to the matrix -- getting ahead of this: https://twitter.com/choldgraf/status/1446666661650599936

@codecov

codecov Bot commented Oct 9, 2021

Copy link
Copy Markdown

Codecov Report

Merging #1081 (d7672d2) into master (39089d5) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1081      +/-   ##
==========================================
+ Coverage   81.57%   81.59%   +0.01%     
==========================================
  Files         140      140              
  Lines       15416    15430      +14     
==========================================
+ Hits        12576    12590      +14     
  Misses       2840     2840              
Impacted Files Coverage Δ
openpathsampling/shooting.py 100.00% <0.00%> (ø)
openpathsampling/deprecations.py 100.00% <0.00%> (ø)
openpathsampling/snapshot_modifier.py 100.00% <0.00%> (ø)
openpathsampling/pathmovers/spring_shooting.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39089d5...d7672d2. Read the comment docs.

@sroet

sroet commented Oct 9, 2021

Copy link
Copy Markdown
Member

😆 Great early catch! LGTM

@dwhswenson dwhswenson merged commit dcee878 into openpathsampling:master Oct 9, 2021
@dwhswenson dwhswenson deleted the string-versions branch October 9, 2021 17:46
@dwhswenson dwhswenson mentioned this pull request Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants