Skip to content

unbreak API call to selector.probability_ratio#1082

Merged
dwhswenson merged 2 commits into
openpathsampling:masterfrom
sroet:catch_api_break
Oct 20, 2021
Merged

unbreak API call to selector.probability_ratio#1082
dwhswenson merged 2 commits into
openpathsampling:masterfrom
sroet:catch_api_break

Conversation

@sroet

@sroet sroet commented Oct 19, 2021

Copy link
Copy Markdown
Member

Of course merging #1075 let to a downstream CI of mine failing because it broke some API... 🤦
it errors with:

  File "/builds/sroet/web_throwing/openpathsampling/openpathsampling/pathmover.py", line 841, in _build_sample
    new_snapshot=new_snapshot
TypeError: probability_ratio() got an unexpected keyword argument 'new_snapshot'

This catches the break and raises an appropriate warning instead of failing outright.

@sroet sroet requested a review from dwhswenson October 19, 2021 08:55
@codecov

codecov Bot commented Oct 19, 2021

Copy link
Copy Markdown

Codecov Report

Merging #1082 (b06252e) into master (4cb16cf) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1082   +/-   ##
=======================================
  Coverage   81.56%   81.56%           
=======================================
  Files         140      140           
  Lines       15446    15451    +5     
=======================================
+ Hits        12598    12603    +5     
  Misses       2848     2848
Impacted Files Coverage Δ
openpathsampling/deprecations.py 100.00% <100.00%> (ø)
openpathsampling/pathmover.py 84.33% <100.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cb16cf...b06252e. Read the comment docs.

dwhswenson
dwhswenson approved these changes Oct 20, 2021
View reviewed changes

@dwhswenson dwhswenson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Merging!

@dwhswenson dwhswenson added the bugfix PRs fixing bugs label Oct 20, 2021
@dwhswenson dwhswenson merged commit ea605e8 into openpathsampling:master Oct 20, 2021
@sroet sroet deleted the catch_api_break branch October 20, 2021 14:19
@dwhswenson dwhswenson mentioned this pull request Jan 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dwhswenson dwhswenson dwhswenson approved these changes

Assignees

No one assigned

Labels

bugfix PRs fixing bugs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sroet @dwhswenson