Skip to content

Docs: New Installation docs#1090

Merged
dwhswenson merged 2 commits into
openpathsampling:masterfrom
dwhswenson:docs-install-update
Nov 10, 2021
Merged

Docs: New Installation docs#1090
dwhswenson merged 2 commits into
openpathsampling:masterfrom
dwhswenson:docs-install-update

Conversation

@dwhswenson

Copy link
Copy Markdown
Member

This PR is a rewrite of the installation page of the docs. The old installation page was originally written with the expectation that we'd need to onboard new contributors who had very little Python experience, and that we'd want to give them multiple options for how to get OPS installed.

However, the install docs are one of the first pages users come to. So I've re-written them to be more focused on user concerns. I kept a brief mention of installing by pip/setuptools, but basically assume that if you're doing that, you know what you're doing.

The new docs include also discuss various tools within the molecular simulation ecosystem that OPS integrates with, and they emphasize that all you need to do to get OPS to work with those tools is install them on your system.

Docs-only; this should be immediately ready for review. I will leave it open for at least 24 hours, merging no earlier than Wed 10 Nov 20:00 GMT (15:00 my local).

@dwhswenson dwhswenson added misc PR docs issues/PRs related to documentation labels Nov 9, 2021
@codecov

codecov Bot commented Nov 9, 2021

Copy link
Copy Markdown

Codecov Report

Merging #1090 (73d38fe) into master (ddfe508) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1090   +/-   ##
=======================================
  Coverage   81.56%   81.56%           
=======================================
  Files         140      140           
  Lines       15452    15452           
=======================================
  Hits        12604    12604           
  Misses       2848     2848           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddfe508...73d38fe. Read the comment docs.

@sroet sroet left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update the pip commands to the current recommended python -m pip, and 1 question about py-plumed. LGTM otherwise

Comment thread docs/install.rst Outdated
Comment thread docs/install.rst Outdated
Comment thread docs/install.rst
Co-authored-by: Sander Roet <sanderroet@hotmail.com>

@sroet sroet left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dwhswenson dwhswenson merged commit b619a07 into openpathsampling:master Nov 10, 2021
@dwhswenson dwhswenson deleted the docs-install-update branch November 10, 2021 20:47
@dwhswenson dwhswenson mentioned this pull request Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs issues/PRs related to documentation misc PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants