Fix build for OpenMM RCs#1093
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1093 +/- ##
=======================================
Coverage 81.56% 81.56%
=======================================
Files 140 140
Lines 15452 15452
=======================================
Hits 12604 12604
Misses 2848 2848 Continue to review full report at Codecov.
|
|
Yep, it was just a matter of needing to pin Python to 3.9, as can be seen in 6648835. Figuring out the issue with Python 3.10 will be future work; it is probably in an (optional) integration requirement, since conda-forge opened a PR to release OPS against Python 3.10 in our feedstock. In additional good news, the tests against the RC pass, so it looks like we have no problems with the RC this time. This is ready for review and comment. I will leave it open for at least 8 hours, merging no earlier than Wed 15 Dec 00:00 GMT (Tue 14 Dec 19:00 my local). |
|
LGTM, do you mind making an issue to remember to undo this? |
Our automated check against new OpenMM release candidates picked up a new RC last night, and the build is failing with a conda
UnsatifiableError. I'm going to try to fix this on our side. Among other things, it seems like there's a weird combination trying to pull inpython=3.10while also pulling inpypy3.6, which seems like an obvious source of conflict. We don't currently test against 3.10, so I'm guessing that's the issue (this fails before we try to install the OpenMM RC, so I suspect the problem due to changes in the GitHub Actions environment, not due to the RC itself).I'll do a little on this now, but if my first tries don't solve, I'll come back to it later in the day (after 19:00 GMT).
The offending conda command in line 17 in the "Install requirements" stage: