update copyright to 2022#1097
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1097 +/- ##
=======================================
Coverage 81.76% 81.76%
=======================================
Files 142 142
Lines 15604 15604
=======================================
Hits 12758 12758
Misses 2846 2846 Continue to review full report at Codecov.
|
dwhswenson
left a comment
There was a problem hiding this comment.
Looks mostly good to me (after I added a commit to update LICENSE as well). One question is whether to change the name list in the docs copyright notice. That text shows up in the footer of every page in the docs, and I think it should be considered as primarily relating to the docs, as opposed to the code, which is covered in LICENSE. (Though, obviously, the code is used to generate the docs.)
I think this should acknowledge the existence of contributors beyond the original "gang of 4" that it currently lists. There are a few options here:
the contributors to OpenPathSampling: this is the text used in the license, which puts no emphasis on any particular personDavid W.H. Swenson, Jan-Hendrik Prinz, John Chodera, Peter Bolhuis, and other contributors to OpenPathSampling: This is a bit wordy, but keeps everyone listed who is currently listedDavid W.H. Swenson and other contributors to OpenPathSampling: here I'm taking credit for the fact that nearly all the text in the docs directory was written by me (which means that if any explanations on the website are poorly written, that's probably also my fault)
Any thoughts?
Depends on your commitment to keeping them up to date 😉. If you are committed to that, I would go for option 3 (as you said, you are responsible for most of the text), otherwise I would go for option 1. (no one particular claims responsibility). However, I would at least ping the other contributors if you plan on dropping their names. |
|
Not worrying about changing who the copyright credits right now. Let's merge this instead of waiting until 2023. 🤣 |
Happy new year!
This updates the copyright I found with
grep -rl "2021" ./ --exclude=*.{pdb}