Skip to content

revert openmmtools import guard from test notebook#1106

Merged
dwhswenson merged 1 commit into
openpathsampling:masterfrom
sroet:revert_openmmtools_notebook
Jul 24, 2022
Merged

revert openmmtools import guard from test notebook#1106
dwhswenson merged 1 commit into
openpathsampling:masterfrom
sroet:revert_openmmtools_notebook

Conversation

@sroet

@sroet sroet commented Feb 8, 2022

Copy link
Copy Markdown
Member

with openmmtools 0.21.0 released this guard against the import warning introduced in #1091 is not needed anymore

@codecov

codecov Bot commented Feb 8, 2022

Copy link
Copy Markdown

Codecov Report

Merging #1106 (0b2eb39) into master (9131891) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1106   +/-   ##
=======================================
  Coverage   81.75%   81.75%           
=======================================
  Files         142      142           
  Lines       15612    15612           
=======================================
  Hits        12764    12764           
  Misses       2848     2848           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9131891...0b2eb39. Read the comment docs.

@sroet

sroet commented Feb 8, 2022

Copy link
Copy Markdown
Member Author

@dwhswenson all green, ready for a review

@sroet sroet requested a review from dwhswenson February 8, 2022 14:40

@dwhswenson dwhswenson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally getting back to some of the easy OPS stuff after 6 months of dealing with new job and moving.... LGTM

@dwhswenson dwhswenson merged commit f39808a into openpathsampling:master Jul 24, 2022
@sroet sroet deleted the revert_openmmtools_notebook branch July 25, 2022 08:19
@dwhswenson dwhswenson mentioned this pull request Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants