Use MDTraj codecs in SimStore JSON serialization#1116
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Well this is an embarrassing bugfix to have missed for so long. @sroet, could you spare 30 seconds to review my fix of this facepalm?
I will merge this immediately after review or after it sits open for over 24 hours, merging around Tue 02 Aug 23:00 GMT (18:00 my local).
@ShenWenHuibit: This should fix the current problem you're having. If you can do a developer install using the fork
dwhswensonand branchuse-mdtraj-codec, you should be able to try it out immediately.