Updates for SQLAlchemy 2.0#1130
Merged
Merged
Conversation
SQLAlchemy 2.0 has been released, and SimStore tests are failing now. There were warnings in 1.4 that help migrate to the 2.0 API. This implements those changes.
Codecov ReportBase: 81.76% // Head: 81.75% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1130 +/- ##
==========================================
- Coverage 81.76% 81.75% -0.01%
==========================================
Files 142 142
Lines 15612 15612
==========================================
- Hits 12765 12764 -1
- Misses 2847 2848 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Member
Author
|
This is ready for review and comment. I will leave it open for at least 24 hours, merging no earlier than Mon 30 Jan 21:00 GMT (15:00 my local). |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SQLAlchemy 2.0 has been released, and SimStore tests are failing now. There were warnings in 1.4 that help migrate to the 2.0 API. This implements those changes.
Still have a couple places where I want to manually check the SQL output to ensure that this is the same, but this PR will fix current errors.