Fix a few more setup -> setup_method tests#1142
Merged
dwhswenson merged 3 commits intoApr 23, 2024
Merged
Conversation
Member
Author
|
Current failure here is because the newer pytest requires nbval 0.10.0, which we pin to avoid against because it broke notebook tests (outputs changed). This will take a little work to resolve. |
For some reason, if you silence output with a ; in an ipynb, nbval still gets the original output and expects that. I think this is a bug, but apparently they haven't fixed this yet.
Member
Author
|
Finally getting CI to green again! See top post for updated contents of this PR. This is ready for review and comment. Without review, I will merge this after at least 18 hours, no sooner than Tue 23 Apr 19:00 GMT (14:00 my local). |
sroet
approved these changes
Apr 23, 2024
sroet
left a comment
Member
There was a problem hiding this comment.
I assume the ipynb changes outside of "# NBVAL_IGNORE_OUTPUT are just some other update diffs? LGTM otherwise
Member
Author
|
Yeah, the other notebook changes were just "rerun the notebook with updated software and maybe that will fix it?" before actually having to look in detail at the problem. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #1123, most of our setup/teardown methods were fixed to use pytest's preferred (and now required)
setup_method/teardown_methodnomenclature. This fixes a few more.UPDATE: This fixes 3 problems caused by upstream breaking changes:
setup_method/teardown_methodinstead ofsetupandteardown.;are seen by nbval as output. This required usingNBVAL_IGNOREin some notebooks.