Custom PathDensityHistogram._add_ops_trajectory#1154
Merged
dwhswenson merged 2 commits intoAug 13, 2024
Conversation
This adds a touch point for path density histogram subclasses to change what occurs when adding an OPS trajectory to a PathDensityHistogram. I needed this when playing with the idea of having a custom histogram that would also track all trajectories that passed through a given histogram bin.
Member
Author
|
This is ready for review and comment. Without review, I will merge this after at least 24 hours, no sooner than Wed 14 Aug 03:00 GMT (Tue 13 Aug 23:00 my local). |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1154 +/- ##
=======================================
Coverage 81.28% 81.28%
=======================================
Files 142 142
Lines 15639 15641 +2
=======================================
+ Hits 12712 12714 +2
Misses 2927 2927 ☔ View full report in Codecov by Sentry. |
PathDensityHistogram._ops_add_trajectory
PathDensityHistogram._ops_add_trajectoryPathDensityHistogram._add_ops_trajectory
sroet
approved these changes
Aug 13, 2024
sroet
left a comment
Member
There was a problem hiding this comment.
looks like a trivial refactor. LGTM!
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a touch point for path density histogram subclasses to change what occurs when adding an OPS trajectory to a PathDensityHistogram.
I needed this when playing with the idea of having a custom histogram that would also track all trajectories that passed through a given histogram bin.
This doesn't break the API, and doesn't even need changes in the tests.