Fix problems with storage for nonperiodic systems#835
Merged
dwhswenson merged 4 commits intoJul 27, 2019
Conversation
(for nonperiodic storage)
current snapshot accepts non periodic systems
Member
Author
|
This is ready for review. @ajsilveira : I assume that this (including your addition) has fixed the problem for you? If so, then I'll leave this up until at least the end of Friday for comments before merging it myself. |
Contributor
|
@dwhswenson yes, it worked for me. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #832. Currently, netcdfplus creates a storage space for box vectors as
n_spatialxn_spatialarrays. If you create a nonperiodic system, the box vectors areNone. When trying to save the snapshot, it raises an error, sinceNonecan't be reshaped into the correct size array.Here, I modify the
StaticContainerStoresuch that it will convert box vectorsNoneto an array of all zeros for storage, and when loading, will convert a box vector array of all zeros toNone.