Fix bug with left_bin_edge in histogram#851
Merged
Merged
Conversation
dwhswenson
approved these changes
Aug 14, 2019
dwhswenson
left a comment
Member
There was a problem hiding this comment.
LGTM. I re-ran the Travis build a couple of times in the hopes that (supposedly now-working) coveralls would confirm that this does not reduce test coverage. Coveralls doesn't seem to be fully working, though.
From looking at the code, I see no way this could be a coverage decrease, and it is most likely a small coverage increase. Will merge.
LookupFunction
LookupFunction
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When trying to do TIS analysis I ran into a bug where the
min_binlocation was either inbin_spaceor incv_spacewhich led to a mismatch between bins and counters.This became apparent by
reverse_cumulativereturning0instead of aLookUpFunction.The mismatch has been fixed and
(reverse_)cumulativenow gives aUserWarningif the total sum is0and now returns a LookUpFunction with only zeros.