Add information to MinusMove change.details#874
Merged
Conversation
Member
Author
|
Tests pass; this is ready for review and merge. I'll leave it up for at least 48 hours for comment (really, probably won't merge it before Sat 16 Nov). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the
MinusMovesaves no details. Theoretically, that's fine, because everything is accessible in its subchanges. But practically speaking, asking users to spelunk through the subchanges is a terrible user experience. This brings a couple of things into aDetailsobject saved by theMinusMovein itschange:segment_swap_samples: The samples used in the initial replica exchange between the innermost ensemble and the "segment" of the minus ensemble.extension_trajectory: The trial trajectory made by the extension phase of the minus move.Idea comes from #873.