Set reject_bytes=False for ujson >= 3#917
Merged
Merged
Conversation
dwhswenson
approved these changes
Jun 4, 2020
dwhswenson
left a comment
Member
There was a problem hiding this comment.
Looks good to me; thanks for the fix! I guess I'm glad to see that ujson is no longer dormant -- a while ago, I thought it was abandoned, but looks like someone has brought it back to active development.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since
ujsonversion3.0.0tests based on openpathsampling saving start failing.ujson.dump()now has default keywordreject_bytes=Truewhich leads to issues for dumping CV's (which contain bytestrings).I had to do some import
ifstatements as well as this keyword is not valid forujson=2.x(And I supposed you still wanted to support that version.)