Clean up devtools#927
Conversation
|
Regarding the name for the import sys
import collections
import importlib_metadata
extras = []
for mod in sys.modules:
try:
pkg_extras = importlib_metadata.metadata(mod).get_all('Provides-Extra')
except importlib_metadata.PackageNotFoundError:
pass
else:
if pkg_extras is not None:
extras.extend(pkg_extras)
print(collections.Counter(extras)) |
|
I do not have any preference on |
|
Thanks @hejung : that seems like a good reason to switch to |
|
This is now ready. A few things this does:
|
We've gone through a lot of changes and experimental approaches to handle CI over the years, and often we've left behind cruft from a previous approach (this was been especially true when either I or @jhprinz want to try a new approach, and don't know which files from the other person's work might break something else).
This PR is aimed at simplifying that, and getting rid of extra files that aren't used and only serve to add confusion to new developers. It will also replace some really old scripts with better approaches.
In particular, this completely removes the old conda recipe. We haven't used conda-build to build the project in ages (and never really needed to, anyway). That, and some of the other stuff in devtools, existed because we copied our skeleton from MDTraj.
This creates a setuptools "extras" target called
testing. I'll add a comment below for details on the name choice: I'm open to other option (test?tests?), but I want to do whatever is most common in the broader community.Anyway, this will make no difference to users, but may help developers contribute more. And there won't be all this extra stuff to annoy me.
conda_install_reqs.shscriptpinnedautorelease_check.pyto devtools directoryThis certainly isn't final word on cleaning up our devtools directory, but this is the once-every-five-years cleanup that is sorely needed.