SimStore part 2: Storable functions (and more)#929
Merged
dwhswenson merged 37 commits intoOct 31, 2020
Conversation
Start to safemode; not sure that it works yet. Still need to get the storable function results to store correctly
... with tests!
Needs tests!
This was mainly causing errors in tests
7 tasks
2 tasks
Member
Author
|
This is ready for review and comment. Since this is another big PR, I will leave it open for at least a week, merging no earlier than Sat 31 Oct 13:00 local (12:00 GMT). An example showing how to use this is in dwhswenson/ops-storage-notebooks#5, in the The good news is, these are the two really big SimStore PRs. From here, I can add smaller chunks that might actually be reviewable. |
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the second PR in the process of updating the OPS storage subsystem, following on #928. See #928 for overall motivation.
Major improvements in this PR:
StorableFunction: a new base class for CVs that is designed to handle parallel simulationstorageobject it saved tosnapshotstable that combines all the individual (engine-specific) snapshot tables.This includes #928, and therefore should only be merged after that.