Make more deterministic test for shooting point selector#964
Merged
dwhswenson merged 4 commits intoJan 22, 2021
Conversation
Codecov Report
@@ Coverage Diff @@
## master #964 +/- ##
=======================================
Coverage 80.25% 80.25%
=======================================
Files 136 136
Lines 14449 14449
=======================================
Hits 11596 11596
Misses 2853 2853 Continue to review full report at Codecov.
|
dwhswenson
approved these changes
Jan 22, 2021
dwhswenson
left a comment
Member
There was a problem hiding this comment.
LGTM. I think I mentioned recently that there may be a couple tests that are flaky with regards to coverage -- that is, some small fraction of lines are sometimes covered, sometimes not. This is one are where I remember that being the case. On Coveralls we allowed some small drop; we don't (yet) on CodeCov. Thanks for the fix, and the update to pytest-style!
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the doc update #963, I saw from codecov that the following line was not reliably hit in
shooting.py:This adds a test to force that code path in the first commit: 1842ed9
The second commit (31e11bf) drops
nosein thetest_shooting.pyand usespytestinstead as an incremental update towards #756Edit: (dc6e428) removes the duplicate of the test added in the first commit (I had copied it to a different spot around in the first commit, but forgot to remove the original one 🤦 )