Add Python 3.8, 3.9 to testing matrix#993
Conversation
|
I suspect that the current failure is due to something changing in Python internals that breaks OPS storage between different versions. Most likely, a change in bytecode. OPS stores the bytecode of CVs, and bytecode can change between Python minor versions. This means that files should only be opened with the same version of Python (or need to be opened in safe mode). We had to make a change based on this when Python 3.6 came out. |
|
from looking at case $PYTHON_VERSION in
"2.7")
mstis=$dropbox_base_url/1x4ny0c93gvu54n/toy_mstis_1k_OPS1.nc
mistis=$dropbox_base_url/qaeczkugwxkrdfy/toy_mistis_1k_OPS1.nc
;;
"3.6")
mstis=$dropbox_base_url/1ulzssv5p4lr61f/toy_mstis_1k_OPS1_py36.nc
mistis=$dropbox_base_url/76981cbgxm639m3/toy_mistis_1k_OPS1_py36.nc
;;
"3.7")
mstis=$dropbox_base_url/1ulzssv5p4lr61f/toy_mstis_1k_OPS1_py36.nc
mistis=$dropbox_base_url/76981cbgxm639m3/toy_mistis_1k_OPS1_py36.nc
;;
*)
echo "Unsupported Python version: $PYTHON_VERSION"
esac(As 3.6 and 3.7 already are identical?) |
|
(if that is the case, please also make a note in |
|
@sroet : Yes, that's pretty much it. Basically, I think all I need to do is re-run the example in each version of Python, and then save the file with 1000 MC steps (which should be enough that TIS analysis has enough overlap), stick that in my Dropbox, and update with the appropriate links. Adding a comment to the CI yml is a good idea. It isn't that you necessarily need to do this every time (the file from 3.6 also works with 3.7), but it is a problem that can occur and should be straightforward to fix when it comes up. Probably won't get to that today, though. |
Codecov Report
@@ Coverage Diff @@
## master #993 +/- ##
==========================================
+ Coverage 80.62% 81.15% +0.52%
==========================================
Files 138 138
Lines 14695 15118 +423
==========================================
+ Hits 11848 12269 +421
- Misses 2847 2849 +2
Continue to review full report at Codecov.
|
|
Summary of changes here:
|
|
This is ready for review and comment. I will leave it open for at least 24 hours, merging no earlier than Wed 07 Apr 20:00 GMT (22:00 local). |
sroet
left a comment
There was a problem hiding this comment.
LGTM, thanks for adding the data-generation script!
OpenMM and OpenMMTools are now available on conda-forge (and therefore available for Python > 3.7). Resolves #864.
Because we release via conda-forge, we already release on 3.8 and 3.9, but they haven't been in our test matrix on CI.